Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IME] Placeholders are visible while typing in the composition #12389

Closed
Acrophost opened this issue Sep 1, 2022 · 4 comments
Closed

[IME] Placeholders are visible while typing in the composition #12389

Acrophost opened this issue Sep 1, 2022 · 4 comments
Assignees
@niegowski
Labels
domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 58 (v35...

Comments

@Acrophost
Copy link

📝 Provide detailed reproduction steps (if any)

  1. Open all features manual test
  2. Add a caption to any table/image
  3. Start inputting the caption

✔️ Expected result

The placeholder disappears as soon as any content is added to caption.

❌ Actual result

The placeholder is still visible while adding content to caption.

Screen.Recording.2022-09-01.at.10.04.34.mov

📃 Other details

  • Browser: Chrome, Safari, Mozilla Firefox
  • OS: MacOS Monterey 12.5.1
  • Language: any language with non latin based alphabet (Japanese, Chinese, Korean) - although in case of Korean the placeholder disappears after adding 3 signs
  • Branch: ck/11438-beforeinput-ime-research-vol1.1-android

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@Acrophost Acrophost added type:bug This issue reports a buggy (incorrect) behavior. domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). squad:core Issue to be handled by the Core team. labels Sep 1, 2022
@dufipl
Copy link
Contributor

dufipl commented Oct 6, 2022

Actually, this applies to all placeholders e.g. editor placeholder or comment placeholder. Changing the title accordingly.

@dufipl dufipl changed the title [IME] Caption placeholder is still visible while typing image/table caption in composition [IME] Plceholders are visible while typing in the composition Oct 6, 2022
@dufipl dufipl changed the title [IME] Plceholders are visible while typing in the composition [IME] Placeholders are visible while typing in the composition Oct 6, 2022
@niegowski niegowski self-assigned this Oct 11, 2022
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Oct 11, 2022
@dufipl
Copy link
Contributor

dufipl commented Oct 12, 2022 •
edited
Loading

Issue looks like resolved on the ck/12389 branch. 👍 @Acrophost please confirm :)

@Acrophost
Copy link
Author

Can't reproduce, so I confirm :D Closing

@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Oct 12, 2022
@niegowski
Copy link
Contributor

I want to complete this issue in a separate PR (it's not complete yet) so I'm reopening this.

@niegowski niegowski reopened this Oct 12, 2022
@niegowski niegowski mentioned this issue Oct 12, 2022
Merged
arkflpc added a commit that referenced this issue Oct 13, 2022
@arkflpc
Merge pull request #12639 from ckeditor/ck/12389
885dc2e 
Fix (engine): The placeholder should not be visible while composing. Closes #12389.
@arkflpc arkflpc closed this as completed Oct 13, 2022
@arkflpc arkflpc added this to the iteration 58 milestone Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

Labels
domain:typing/ime This issue reports a problem with standard typing & IME (typing method for CJK languages). squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 58 (v35.3.0)
Development

No branches or pull requests
5 participants
@niegowski @arkflpc @CKEditorBot @dufipl @Acrophost