Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LabeledFieldView should be extendable #12598

Closed
oleq opened this issue Oct 7, 2022 · 0 comments · Fixed by #12622
Closed

LabeledFieldView should be extendable #12598

oleq opened this issue Oct 7, 2022 · 0 comments · Fixed by #12622
Assignees
Labels
package:ui squad:features Issue to be handled by the Features team. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@oleq
Copy link
Member

oleq commented Oct 7, 2022

📝 Provide a description of the improvement

ATM if you want to put anything next (or over) the input like additional elements (an icon, a button to clear the input), there's no way to do that because children are hardcoded

children: [
{
tag: 'div',
attributes: {
class: [
'ck',
'ck-labeled-field-view__input-wrapper'
]
},
children: [
this.fieldView,
this.labelView
]
},
this.statusView

The solution is to make the input wrapper a real view with a children collection you can push extra things into.


If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@oleq oleq added type:improvement This issue reports a possible enhancement of an existing feature. package:ui labels Oct 7, 2022
@oleq oleq self-assigned this Oct 7, 2022
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Oct 7, 2022
@oleq oleq added squad:features Issue to be handled by the Features team. and removed status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. labels Oct 7, 2022
niegowski added a commit that referenced this issue Oct 11, 2022
…eld-view

Other (ui): Allowed inserting extra children next to the field inside `LabeledFieldView`. Closes #12598
@CKEditorBot CKEditorBot added this to the iteration 58 milestone Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:ui squad:features Issue to be handled by the Features team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants