Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS MVP] Add strongly-typed commands #12678

Closed
arkflpc opened this issue Oct 19, 2022 · 0 comments · Fixed by #12683
Closed

[TS MVP] Add strongly-typed commands #12678

arkflpc opened this issue Oct 19, 2022 · 0 comments · Fixed by #12683
Labels
domain:ts squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 58 (v35...

Comments

@arkflpc
Copy link
Contributor

arkflpc commented Oct 19, 2022

CommandCollection.execute() and Editor.execute() should check execute parameters based on command name.
@arkflpc arkflpc added domain:ts squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos". labels Oct 19, 2022
@arkflpc arkflpc mentioned this issue Oct 19, 2022
Merged
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Oct 19, 2022
arkflpc added a commit that referenced this issue Oct 19, 2022
@arkflpc
Merge pull request #12683 from ckeditor/ck/12678-ts-typed-commands
f94839e 
Other: Adds types for CommandCollection.execute() and Editor.execute(). Closes #12678.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Oct 19, 2022
@CKEditorBot CKEditorBot added this to the iteration 58 milestone Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain:ts squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 58 (v35.3.0)
Development

Successfully merging a pull request may close this issue.

Ck/12678 ts typed commands ckeditor/ckeditor5
2 participants
@arkflpc @CKEditorBot