Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move EditorUI to ckeditor5-ui #12853

Closed
Tracked by #12027
arkflpc opened this issue Nov 16, 2022 · 0 comments · Fixed by #12991
Closed
Tracked by #12027

Move EditorUI to ckeditor5-ui #12853

arkflpc opened this issue Nov 16, 2022 · 0 comments · Fixed by #12991
Assignees
@arkflpc
Labels
domain:ts package:core package:ui squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 60 (v36...

Comments

@arkflpc
Copy link
Contributor

arkflpc commented Nov 16, 2022 •
edited by Reinmar
Loading

There is circular dependency between ckeditor5-core and ckeditor5-ui packages. The problematic class is EditorUI that has dependency to ckeditor5-ui. The idea is to move EditorUI to ckeditor5-ui.

It would allow full implementation of #12720 (so that imports from other packages are only through index.ts, now it is not fully possible because of this circular dependency).

Scope:

Out of scope:

  • ClassicTestEditor etc. can stay where it is.
  • Editor class may import EditorUI as import type (circular type dependencies are ok).

This will be minor breaking change.
@arkflpc arkflpc added squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos". labels Nov 16, 2022
@arkflpc arkflpc self-assigned this Dec 7, 2022
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Dec 7, 2022
@arkflpc arkflpc mentioned this issue Dec 8, 2022
Merged
arkflpc added a commit that referenced this issue Dec 19, 2022
@arkflpc
Merge pull request #12991 from ckeditor/ck/12853-move-editorui-to-ui
7db6646 
Other (core, ui): Moves `EditorUI` from `ckeditor5-core` to `ckeditor5-ui`. Closes #12853.

MAJOR BREAKING CHANGE: The `EditorUI` class was moved from `@ckeditor/ckeditor5-core` to `@ckeditor/ckeditor5-ui`. Thus, it's enough to update imports (depending on the format used):

*   from `'ckeditor5/src/core'` to `'ckeditor5/src/ui'`
*   from `'@ckeditor/ckeditor5-core/src/editor/editorui'` to `'@ckeditor/ckeditor5-ui/src/editorui/editorui'`
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Dec 19, 2022
@CKEditorBot CKEditorBot added this to the iteration 60 milestone Dec 19, 2022
@Witoso Witoso mentioned this issue Apr 4, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arkflpc arkflpc

Labels
domain:ts package:core package:ui squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 60 (v36.0.0)
Development

Successfully merging a pull request may close this issue.

Ck/12853 move EditorUI to ui ckeditor/ckeditor5
3 participants
@Reinmar @arkflpc @CKEditorBot