-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
text
should not be an obligatory property in MentionFeedObjectItem
type
#13550
Labels
domain:ts
package:mention
squad:features
Issue to be handled by the Features team.
type:task
This issue reports a chore (non-production change) and other types of "todos".
Milestone
Comments
Dumluregn
added
type:task
This issue reports a chore (non-production change) and other types of "todos".
package:mention
domain:ts
labels
Feb 24, 2023
Changing the |
CKEditorBot
added
the
status:planned
Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon.
label
Feb 27, 2023
CKEditorBot
added
status:in-progress
Set automatically when an issue lands in the "In progress" column. We are working on it.
and removed
status:planned
Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon.
labels
Feb 27, 2023
niegowski
added a commit
that referenced
this issue
Feb 27, 2023
…ty-in-mentions Fix (mention): Make a text property optional in `MentionFeedObjectItem` type. Closes #13550.
CKEditorBot
removed
the
status:in-progress
Set automatically when an issue lands in the "In progress" column. We are working on it.
label
Feb 27, 2023
pomek
pushed a commit
that referenced
this issue
Feb 28, 2023
…ty-in-mentions Fix (mention): Make a text property optional in `MentionFeedObjectItem` type. Closes #13550.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
domain:ts
package:mention
squad:features
Issue to be handled by the Features team.
type:task
This issue reports a chore (non-production change) and other types of "todos".
📝 Details
In https://github.com/ckeditor/ckeditor5/blob/dd8827aac5e53fcd311982fbff70fc83fb0a4c3b/packages/ckeditor5-mention/src/mentionconfig.ts#L281,
text
is defined as an obligatory property inMentionFeedObjectItem
type. If you use a customItemRenderer
, it isn't necessary though - you can use other properties to derive the output HTML element. This is done e.g. in the manual test.This is a soft blocker for the feature customisation written in TS. It requires using double casting the callbacks through type
unknown
when passingmention.feeds.feed
andmentions.feeds.itemRenderer
properties:The text was updated successfully, but these errors were encountered: