Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of Ctrl + A in input field in dropdown views #13982

Closed
mmotyczynska opened this issue Apr 26, 2023 · 0 comments · Fixed by #13990
Closed

Better handling of Ctrl + A in input field in dropdown views #13982

mmotyczynska opened this issue Apr 26, 2023 · 0 comments · Fixed by #13990
Assignees
@mmotyczynska
Labels
squad:features Issue to be handled by the Features team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 63 (v38...

Comments

@mmotyczynska
Copy link
Contributor

Provide a description of the task

We should improve selecting all content in input fields that are placed in dropdown views.
Currently by default it's not possible to select content in such input with Ctrl + A. To make it possible every time we block selectstart like this:

this.listenTo( childViews[ 0 ].element!, 'selectstart', ( evt, domEvt ) => {
	domEvt.stopPropagation();
}, { priority: 'high' } );

📃 Other details

  • Browser: …
  • OS: …
  • CKEditor version: …
  • Installed CKEditor plugins: …
@mmotyczynska mmotyczynska added type:task This issue reports a chore (non-production change) and other types of "todos". squad:features Issue to be handled by the Features team. labels Apr 26, 2023
@mmotyczynska mmotyczynska self-assigned this Apr 26, 2023
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Apr 26, 2023
@mmotyczynska mmotyczynska mentioned this issue Apr 27, 2023
Merged
arkflpc added a commit that referenced this issue May 8, 2023
@arkflpc
Merge pull request #13990 from ckeditor/ck/13982-better-handling-of-c…
7846683 
…trl-a-in-input-in-dropdown-view

Fix (ui): Select all (Ctrl+A) should now be enabled by default in input field placed in dropdown panel. Closes #13982.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label May 8, 2023
@CKEditorBot CKEditorBot added this to the iteration 63 milestone May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmotyczynska mmotyczynska

Labels
squad:features Issue to be handled by the Features team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 63 (v38.0.0)
Development

Successfully merging a pull request may close this issue.

Better handling of Ctrl+a in input in dropdown views ckeditor/ckeditor5
2 participants
@CKEditorBot @mmotyczynska