Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enablePlaceholder() API should remain backward compatible for some time #14743

Closed
mlewand opened this issue Aug 3, 2023 · 0 comments · Fixed by #14753
Closed

enablePlaceholder() API should remain backward compatible for some time #14743

mlewand opened this issue Aug 3, 2023 · 0 comments · Fixed by #14753
Assignees
@illia-stv
Labels
intro Good first ticket. squad:features Issue to be handled by the Features team. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 66 (v39...

Comments

@mlewand
Copy link
Contributor

mlewand commented Aug 3, 2023

📝 Provide a description of the improvement

enablePlaceholder() is used more commonly than we anticipated.

It's possible to introduce our change in a backward-compatible way. We just need to keep support text option passed to this helper which will set the .placeholder property on a passed element.

However, using the old API should leave a notice in the dev console that you're using old API which will be replaced soon.

Note, that this console log must not appear more than once during a given page reload.

📃 Other details

  • Browser: …
  • OS: …
  • CKEditor version: …
  • Installed CKEditor plugins: …

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@mlewand mlewand added type:improvement This issue reports a possible enhancement of an existing feature. intro Good first ticket. squad:features Issue to be handled by the Features team. labels Aug 3, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Aug 3, 2023
@illia-stv illia-stv self-assigned this Aug 4, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Aug 4, 2023
@illia-stv illia-stv mentioned this issue Aug 4, 2023
Merged
mlewand added a commit that referenced this issue Aug 7, 2023
@mlewand
Merge pull request #14753 from ckeditor/ck/14743-enablePlaceholder-AP…
8936e0e 
…I-should-remain-backward-compatible-for-some-time

Fix (engine): Made the `enablePlaceholder()` API to remain backward compatible for the deprecation period. It will be removed in the future. Closes #14743.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Aug 7, 2023
@CKEditorBot CKEditorBot added this to the iteration 66 milestone Aug 7, 2023
@CKEditorBot CKEditorBot mentioned this issue Aug 7, 2023
Open
pomek pushed a commit that referenced this issue Aug 8, 2023
@mlewand @pomek
Merge pull request #14753 from ckeditor/ck/14743-enablePlaceholder-AP…
048ed18 
…I-should-remain-backward-compatible-for-some-time

Fix (engine): Made the `enablePlaceholder()` API to remain backward compatible for the deprecation period. It will be removed in the future. Closes #14743.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@illia-stv illia-stv

Labels
intro Good first ticket. squad:features Issue to be handled by the Features team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 66 (v39.0.2)
Development

Successfully merging a pull request may close this issue.

enablePlaceholder() API should remain backward compatible for some time ckeditor/ckeditor5
3 participants
@mlewand @CKEditorBot @illia-stv