Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot undo in empty content in Balloon block editor [mobile] #1543

Closed
jodator opened this issue Feb 19, 2019 · 6 comments Β· Fixed by ckeditor/ckeditor5-build-balloon-block#9
Closed
Assignees
Labels
browser:android browser:chrome type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@jodator
Copy link
Contributor

jodator commented Feb 19, 2019

Is this a bug report or feature request? (choose one)

Other

πŸ’» Version of CKEditor

latest master

πŸ“‹ Steps to reproduce

  1. Go to the ballon block editor docs page
  2. Select all content
  3. Cut it
  4. Try to undo

βœ… Expected result

The undo button be somewhere

❎ Actual result

No undo button

πŸ“ƒ Other details that might be useful

Chrome@Android

I can see only native menu on long touch, the backwards-P toolbar has no undo/redo buttons:
2019-02-19 14 58 34

@jodator jodator added type:improvement This issue reports a possible enhancement of an existing feature. status:confirmed browser:android browser:chrome labels Feb 19, 2019
@jodator
Copy link
Contributor Author

jodator commented Feb 20, 2019

I'd move the undo/redo buttons from selection toolbar to the block toolbar which is always visible

@Reinmar
Copy link
Member

Reinmar commented Feb 20, 2019

It may be a good idea. But... then we violate the "block" thing in "block toolbar" cause undo/redo are just generic buttons.

It's also a part of bigger issue with contentEditable that we cannot listen to the native undo/redo: w3c/editing#150

@Reinmar
Copy link
Member

Reinmar commented Mar 18, 2019

cc @oleq @dkonopka

@oleq
Copy link
Member

oleq commented Mar 20, 2019

It does not feel like a big issue to me moving those buttons to the block toolbar. Sooner or later other buttons not quite related to block will need to land there, like, for instance, track changes controls.

@Reinmar Reinmar added this to the iteration 23 milestone Mar 25, 2019
@mlewand mlewand modified the milestones: iteration 23, iteration 24 Apr 8, 2019
@mlewand mlewand modified the milestones: iteration 24, iteration 25 May 13, 2019
@pomek
Copy link
Member

pomek commented May 30, 2019

A serious question - do I need a device with Android to reproduce this issue?

@Reinmar
Copy link
Member

Reinmar commented May 30, 2019

I think the same issue is reproducible on iOS. The only requirement is the lack of hardware keyboard.

jodator added a commit to ckeditor/ckeditor5-build-balloon-block that referenced this issue Jun 10, 2019
Other: Moved "Undo" and "Redo" buttons from selection toolbar to block toolbar. Thanks to that, users are able to undo the last step if the editor is empty. Closes ckeditor/ckeditor5#1543.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:android browser:chrome type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants