-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot undo in empty content in Balloon block editor [mobile] #1543
Cannot undo in empty content in Balloon block editor [mobile] #1543
Comments
I'd move the undo/redo buttons from selection toolbar to the block toolbar which is always visible |
It may be a good idea. But... then we violate the "block" thing in "block toolbar" cause undo/redo are just generic buttons. It's also a part of bigger issue with contentEditable that we cannot listen to the native undo/redo: w3c/editing#150 |
It does not feel like a big issue to me moving those buttons to the block toolbar. Sooner or later other buttons not quite related to block will need to land there, like, for instance, track changes controls. |
A serious question - do I need a device with Android to reproduce this issue? |
I think the same issue is reproducible on iOS. The only requirement is the lack of hardware keyboard. |
Other: Moved "Undo" and "Redo" buttons from selection toolbar to block toolbar. Thanks to that, users are able to undo the last step if the editor is empty. Closes ckeditor/ckeditor5#1543.
Is this a bug report or feature request? (choose one)
Other
π» Version of CKEditor
latest master
π Steps to reproduce
β Expected result
The undo button be somewhere
β Actual result
No undo button
π Other details that might be useful
Chrome@Android
I can see only native menu on long touch, the
backwards-P
toolbar has no undo/redo buttons:The text was updated successfully, but these errors were encountered: