Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FocusCycler's focusables collection should contains FocusableViews only #15631

Closed
oleq opened this issue Jan 4, 2024 · 1 comment
Closed
Assignees
Labels
domain:dx This issue reports a developer experience problem or possible improvement. package:ui type:bug This issue reports a buggy (incorrect) behavior.

Comments

@oleq
Copy link
Member

oleq commented Jan 4, 2024

📝 Provide detailed reproduction steps (if any)

ATM it's a plain collection allowing any views and that brings inconsistency to the code because its clear that any view that lands there must be FocusableView.


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. package:ui domain:dx This issue reports a developer experience problem or possible improvement. labels Jan 4, 2024
@oleq oleq self-assigned this Jan 4, 2024
@oleq
Copy link
Member Author

oleq commented Jan 10, 2024

Closed in #15632.

@oleq oleq closed this as completed Jan 10, 2024
@pomek pomek added this to the iteration 70 milestone Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:dx This issue reports a developer experience problem or possible improvement. package:ui type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

2 participants