FocusCycler's #focusables collection should only contain FocusableView instances #15632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleq
force-pushed
the
ck/15631-unified-focuscycler-collection
branch
from
530c13d to
0860906
Compare
scofalik
approved these changes
Jan 5, 2024
arkflpc
approved these changes
Jan 8, 2024
packages/ckeditor5-ui/src/colorselector/colorpickerfragmentview.ts
Outdated
Show resolved
Hide resolved
I think so. Before these changes, developers were able to populate FocusCycler's focusable collection with non-focusable views. It worked because the system has JS mechanisms built-in to work around this. After this PR, their TS projects will show errors and they'll need to stop adding these (invalid) views there. It may involve some conditions or some filtering but still - there will be some action required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other (ui):
FocusCycler's#focusablescollection should only containFocusableViewinstances. Closes #14973.MINOR BREAKING CHANGE (ui): The view collection
focusablesrequired byFocusCycler#constructor()must only contain views implementing theFocusableViewinterface. Failing to do so will result in a TypeScript error. If your custom code createsFocusCyclerinstances, please make sure that all views passed infocusablesimplement thefocus()method.Additional information
Requires https://github.com/cksource/ckeditor5-commercial/pull/5886