Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to change found text while the dialog is open #15680

Closed
Witoso opened this issue Jan 12, 2024 · 0 comments · Fixed by #15791
Closed

Ability to change found text while the dialog is open #15680

Witoso opened this issue Jan 12, 2024 · 0 comments · Fixed by #15791
Assignees
@Mati365
Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:find-and-replace squad:collaboration Issue to be handled by the Collaboration team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 72 (v41...

Comments

@Witoso
Copy link
Member

Witoso commented Jan 12, 2024

📝 Provide detailed reproduction steps (if any)

  1. Open Find and Replace feature guide (http://127.0.0.1:8080/ckeditor5/latest/features/find-and-replace.html)
  2. Open Find and Replace dialog, type a word that exist in content and click button Find.
  3. Type something in replace with... input (to better see the final "effect").
  4. Now, for exaple, place selection in the middle of the marked word in content and start typing (or like on the video, select part of the word and move it somewhere else).
  5. Hit Replace All button.

✔️ Expected result

If searched words !== word in text, should marked text dissapeared and Replace should not affect this place.

❌ Actual result

296159675-75919c43-8269-4bfc-a248-a615aacb678a.mov

❓ Possible solution

🤔 Maybe it should not be possible to change the marked text or it can be changed but searching should be refreshed?

📃 Other details

  • Browser: …
  • OS: …
  • First affected CKEditor version: …
  • Installed CKEditor plugins: …
@Witoso Witoso added type:bug This issue reports a buggy (incorrect) behavior. intro Good first ticket. package:find-and-replace domain:ui/ux This issue reports a problem related to UI or UX. labels Jan 12, 2024
@DawidKossowski DawidKossowski changed the title Ability to change found text while the dialog is open. Ability to change found text while the dialog is open Feb 1, 2024
@DawidKossowski DawidKossowski added the squad:collaboration Issue to be handled by the Collaboration team. label Feb 2, 2024
@Mati365 Mati365 mentioned this issue Feb 5, 2024
Merged
Dumluregn added a commit that referenced this issue Feb 16, 2024
@Dumluregn
Merge pull request #15791 from ckeditor/ck/15680
c66bb4d 
Feature (find-and-replace): The find and replace feature will dynamically update the search results when the document contents change. Closes #15680.
@CKEditorBot CKEditorBot added this to the iteration 72 milestone Feb 16, 2024
@CKEditorBot CKEditorBot mentioned this issue Feb 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mati365 Mati365

Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:find-and-replace squad:collaboration Issue to be handled by the Collaboration team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 72 (v41.2.0)
Development

Successfully merging a pull request may close this issue.

Fix ability to change found text while the dialog is open ckeditor/ckeditor5
4 participants
@Mati365 @Witoso @DawidKossowski @CKEditorBot