Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add insert image integration for menu bar #16445

Closed
scofalik opened this issue May 29, 2024 · 0 comments · Fixed by #16334 · May be fixed by Klantinteractie-Servicesysteem/KISS-frontend#929
Closed

Add insert image integration for menu bar #16445

scofalik opened this issue May 29, 2024 · 0 comments · Fixed by #16334 · May be fixed by Klantinteractie-Servicesysteem/KISS-frontend#929
Assignees
@scofalik @mremiszewski
Labels
package:ui squad:collaboration Issue to be handled by the Collaboration team. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 75 (v42...

Comments

@scofalik
Copy link
Contributor

📝 Provide a description of the improvement

Insert image component is not integrated with the menu bar as of now. The menu bar integration should behave in a similar way as the toolbar component.

Additionally, we should move the "Insert image via URL" form to a modal dialog.
@scofalik scofalik added type:improvement This issue reports a possible enhancement of an existing feature. package:ui squad:collaboration Issue to be handled by the Collaboration team. labels May 29, 2024
@scofalik scofalik mentioned this issue May 29, 2024
Merged
scofalik added a commit that referenced this issue May 31, 2024
@scofalik
Merge pull request #16334 from ckeditor/ck/app-menu-bar-image-insert
25e13f8 
Feature (image): Added menu bar integration for the insert image component. The `menuBar:insertImage` component is by default added to "Insert" menu and replaces current buttons related to image insertion. Closes #16445.

Fix (image): Buttons inside `insertImage` dropdown will no longer have an unnecessary tooltip.

Other (image): Following new components are now available: `insertImageViaUrl` toolbar button and `menuBar:insertImageViaUrl` menu bar button.

Other (image): "Insert image via URL" form has been move to a modal dialog instead of being available directly in the insert image dropdown.

MINOR BREAKING CHANGE (image): "Insert image via URL" form has been move to a modal dialog instead of being available directly in the insert image dropdown.
@CKEditorBot CKEditorBot added this to the iteration 75 milestone May 31, 2024
@CKEditorBot CKEditorBot mentioned this issue Jun 1, 2024
Open
@KISSAdmin KISSAdmin mentioned this issue Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

@mremiszewski mremiszewski

Labels
package:ui squad:collaboration Issue to be handled by the Collaboration team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 75 (v42.0.0)
3 participants
@scofalik @CKEditorBot @mremiszewski