Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus outline missing on top-level menu bar items upon reaching them by Esc key press #16719

Closed
oleq opened this issue Jul 12, 2024 · 0 comments Β· Fixed by #16908
Closed

Focus outline missing on top-level menu bar items upon reaching them by Esc key press #16719

oleq opened this issue Jul 12, 2024 · 0 comments Β· Fixed by #16908
Assignees
Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.

Comments

@oleq
Copy link
Member

oleq commented Jul 12, 2024

πŸ“ Provide detailed reproduction steps (if any)

  1. Open menu bar.
  2. Go somewhere deep.
  3. Start escaping using Esc.

βœ”οΈ Expected result

When you reach the top-level category such as "Insert", the button should have a focus outline.

❌ Actual result

The focus outline is not there. You have to start navigating horizontally (arrow left/right) to get focus outlines on top-level categories.

Screen.Recording.2024-07-12.at.17.09.25.mov

πŸ“ƒ Other details

I suppose this is an aftermath of hacks that were made to keep the focus outline invisible until the user starts keyboard navigation in the menu bar.


If you'd like to see this fixed sooner, add a πŸ‘ reaction to this post.

@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. package:ui type:regression This issue reports a bug that was not present in the previous releases. labels Jul 12, 2024
@oleq oleq changed the title Focus invisible on the top-level menu bar items upon returning using Esc key Focus outline missing on top-level menu bar items upon reaching them by Esc key press Jul 12, 2024
@oleq oleq self-assigned this Aug 12, 2024
oleq added a commit that referenced this issue Aug 26, 2024
Fix (ui): The focus outline should remain visible upon closing a menu bar using the Esc key during keyboard navigation. Closes #16719.
@CKEditorBot CKEditorBot added this to the iteration 77 milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants