Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic editor's sticky toolbar dialog integration should ignore modals #17339

Closed
oleq opened this issue Oct 28, 2024 · 0 comments · Fixed by #17341
Closed

Classic editor's sticky toolbar dialog integration should ignore modals #17339

oleq opened this issue Oct 28, 2024 · 0 comments · Fixed by #17341
Assignees
Labels
package:editor-classic package:ui type:bug This issue reports a buggy (incorrect) behavior.

Comments

@oleq
Copy link
Member

oleq commented Oct 28, 2024

📝 Provide detailed reproduction steps (if any)

  1. Create a (preferably multi-row) classic toolbar.
  2. Narrow down the viewport (vertically).
  3. Scroll the viewport to get the classic editor sticky.
  4. Open media embed (or any modal).

✔️ Expected result

Modals are displayed in the middle of the page and ignore the classic editor sticky toolbar integration (or viewport offsets, which has already been addressed).

Image

❌ Actual result

Modals are shifted to avoid collision with the toolbar even though they are displayed on top of the page.

Image

❓ Possible solution

Alter the integration 🙂


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:editor-classic package:ui type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants