Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the modals #17290

Closed
oleq opened this issue Oct 21, 2024 · 0 comments · Fixed by #17291
Closed

Improvements to the modals #17290

oleq opened this issue Oct 21, 2024 · 0 comments · Fixed by #17291
Assignees
Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@oleq
Copy link
Member

oleq commented Oct 21, 2024

📝 Provide a description of the improvement

Disable drag and drop on modal windows

A possibility to drag and drop them makes sense when there is no background overlay (plain dialog) but becomes confusing when a modal is displayed.

Screen.Recording.2024-10-21.at.12.46.55.mov

Ignore viewport offset configuration for modal windows

Modals are displayed on the top layer of the page anyway so they don't have to be restricted by the viewport offset configuration of the editor. This will make displaying large modals that consume all available space easier.


If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@oleq oleq added package:ui type:improvement This issue reports a possible enhancement of an existing feature. labels Oct 21, 2024
@oleq oleq self-assigned this Oct 21, 2024
oleq added a commit that referenced this issue Oct 22, 2024
Other (ui): Disabled dragging support for modal windows in the `Dialog` plugin. Closes #17290.

Other (ui): Disabled positioning restrictions for modal windows caused by `config.ui.viewportOffset`. Closes #17290.
@CKEditorBot CKEditorBot added this to the iteration 79 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants