Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triple click into paragraph selects paragraph and next element #1839

Open
lasfin opened this issue Jun 27, 2019 · 5 comments
Open

Triple click into paragraph selects paragraph and next element #1839

lasfin opened this issue Jun 27, 2019 · 5 comments
Labels
browser:chrome status:stale type:bug This issue reports a buggy (incorrect) behavior.

Comments

@lasfin
Copy link

lasfin commented Jun 27, 2019

Is this a bug report or feature request? (choose one)

🐞 Bug report

💻 Version of CKEditor

Latest mater

📋 Steps to reproduce

  1. Open https://ckeditor.com/docs/ckeditor5/latest/examples/builds/classic-editor.html
  2. Triple click on paragraph before image or table

✅ Expected result

Only paragraph is selected

❎ Actual result

Paragraph and image are both selected. (Or paragraph and table if clicked before table)

@lasfin lasfin changed the title Triple-Click of paragraph selects paragraph and next element Triple click into paragraph selects paragraph and next element Jun 27, 2019
@Mgsy
Copy link
Member

Mgsy commented Jul 1, 2019

I can confirm it. It occurs only in Chrome.

@Mgsy Mgsy added browser:chrome status:confirmed type:bug This issue reports a buggy (incorrect) behavior. labels Jul 1, 2019
@Reinmar
Copy link
Member

Reinmar commented Jul 8, 2019

It's a really tricky case to handle. The browser puts the end of the selection in the 2nd line to show that the line break was selected. This makes the end of the selection end up inside the image. Which creates an incorrect state of the model so we want to fix it. And we can either shrink or extend the selection. Since we don't have (at that moment) an information about the origin of the selection change, we always do one thing – we extend the selection.

This can be handled in a better way but it will require siginifican amount of work. Related issue: https://github.com/ckeditor/ckeditor5-widget/issues/83

@Reinmar Reinmar added this to the backlog milestone Jul 8, 2019
mlewand pushed a commit that referenced this issue May 1, 2020
Other: Improved performance of `TreeWalker` by up to 40%. This optimization affects common tasks such as loading editor data. Closes #6582.
@cedric-legallo
Copy link

cedric-legallo commented Jun 29, 2020

Similar to this issue, but maybe it needs another one : When we insert a <br/> in a paragraph (with shift+enter) the triple clic selection stops at the <br/> tag and does not select the whole paragraph.

@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:chrome status:stale type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

7 participants