-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Indent in all builds and BlockIndent in the decoupled-document #1844
Comments
Waiting for ckeditor/ckeditor5-ui#451, for now. Though, the decision still has to be made. Also, perhaps we could have a split button for indentation? If 90% of the time you're indenting things, then perhaps it will be better? It will take less space. |
It's true, we should think all the time about space inside the toolbar, but I have one doubt about this new split button: the icon. How we could visualise indent&outdent together or I just misunderstand you and we will make it same as text alignment? Anyway, some maths here: we could save around 20 pixels (two buttons ~ 60px, when one split button ~40px), so IMHO it's worth to think about it. OTOH, it's still one click more for users to use this feature. Note: I've researched the most popular editors and there is no usage of indent/outdent action inside a dropdown. |
I created a PoC but I don't think we can deliver it in i27:
|
Another PoC except that the main button is always indenting (it does not change its role). |
Feature: Enabled the indent feature in the build. See ckeditor/ckeditor5#1844.
Feature: Enabled the indent feature in the build. See ckeditor/ckeditor5#1844.
Feature: Enabled the indent feature in the build. See ckeditor/ckeditor5#1844.
Feature: Enabled the indent feature in the build. See ckeditor/ckeditor5#1844.
Feature: Enabled the indent feature in the build. See ckeditor/ckeditor5#1844.
I merged @oleq's PR in builds. The remaining things is adding indent/outdent in several guides in the docs. Will handle this. |
☝️ I actually extracted this to #5598 |
OMG, I think I updated all the toolbars that were worth it. But maintaining all those configurations is awful :< |
Feature: Enabled the indent feature in the build. See ckeditor/ckeditor5#1844.
The case with Indent is – we want the indent/outdent buttons in all builds toolbars because it's the only way to indent/outdent lists on mobiles. Related: #868.
The problem – lack of space in their toolbars. Related: #894.
The case with BlockIndent in decoupled-document is quite obvious, I think – it's a document feature.
However, it's an even bigger problem with too many buttons in the toolbar there.
The text was updated successfully, but these errors were encountered: