Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block indentation should be recognized as a formatting attribute #2358

Closed
mlewand opened this issue Aug 12, 2019 · 2 comments · Fixed by #7711
Closed

Block indentation should be recognized as a formatting attribute #2358

mlewand opened this issue Aug 12, 2019 · 2 comments · Fixed by #7711
Assignees
@niegowski
Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:indent type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 35 (v22...

Comments

@mlewand
Copy link
Contributor

mlewand commented Aug 12, 2019

Is this a bug report or feature request?

🆕 Feature request

💻 Version of CKEditor

CKEditor v5 @ 12.3.1

📋 Steps to reproduce

  1. Use a sample with block indentation and remove format plugins.
  2. Indent a paragraph.
  3. Select all.
  4. Use remove format option.

✅ Expected result

Indentation should be gone.

❎ Actual result

Indentation is not removed.

📃 Other details that might be useful

It's enough to add

It should mark the attribute as isFormatting = true using schema#setAttributeProperties.

If you'd like to see this feature implemented, add 👍 to this post.
@jodator
Copy link
Contributor

jodator commented Aug 12, 2019

How does it work in other text processors, like Word?

OTOH I see that Alignment feature is also a formatting attribute so this would go in line with this :)

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-indent Oct 9, 2019
@mlewand mlewand added this to the nice-to-have milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:indent labels Oct 9, 2019
@gauravjain028
Copy link

I am also having the same issue with my custom plugins. Remove format is not considering $block level attributes. Please help.

@Reinmar Reinmar added domain:ui/ux This issue reports a problem related to UI or UX. squad:red labels Jun 18, 2020
@mlewand mlewand added the intro Good first ticket. label Jul 9, 2020
@Reinmar Reinmar mentioned this issue Jul 9, 2020
Closed
@oleq oleq modified the milestones: nice-to-have, iteration 34 Jul 14, 2020
@oleq oleq self-assigned this Jul 15, 2020
@Reinmar Reinmar assigned niegowski and unassigned oleq Jul 21, 2020
@niegowski niegowski mentioned this issue Jul 25, 2020
Merged
@Reinmar Reinmar modified the milestones: iteration 34, iteration 35 Jul 27, 2020
pomek added a commit that referenced this issue Jul 28, 2020
@pomek
Merge pull request #7711 from ckeditor/i/2358
6b2cc25 
Feature (indent): Block indentation should be recognized as a formatting attribute. Closes #2358.

Other (remove-format): Block formatting should be removed if the selection is inside that block. 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:indent type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 35 (v22.0.0)
Development

Successfully merging a pull request may close this issue.

#2358: Block indentation should be recognized as a formatting attribute ckeditor/ckeditor5
6 participants
@Reinmar @jodator @oleq @niegowski @gauravjain028 @mlewand