Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard support for insert table dropdown #3176

Closed
jodator opened this issue May 29, 2018 · 15 comments · Fixed by #12256
Closed

Add keyboard support for insert table dropdown #3176

jodator opened this issue May 29, 2018 · 15 comments · Fixed by #12256
Assignees
Labels
domain:accessibility This issue reports an accessibility problem. package:table squad:features Issue to be handled by the Features team. status:discussion support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@jodator
Copy link
Contributor

jodator commented May 29, 2018

While implementing insert table feature:

selection_053

I've realized that it has no keyboard support defined. But I'd leave it as a followup to focus first on other missing features from MVP.

I also had some minor issues with getting this to work with FocusCycler and using <div tabindex="-1">. Also maybe I'm missing something but with current implementation of above dropdown I'd like to use methods like focus( 10 ) and focus( -10 ) to skip a whole row on arrowup and arrowdown.

For clarity this issue is only about properly handling the keyboard in table dropdown.

@Comandeer

This comment was marked as outdated.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-table Oct 9, 2019
@mlewand mlewand added this to the nice-to-have milestone Oct 9, 2019
@mlewand mlewand added domain:accessibility This issue reports an accessibility problem. status:discussion type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:table labels Oct 9, 2019
@oleq

This comment was marked as outdated.

@dpavez14

This comment was marked as outdated.

@oleq
Copy link
Member

oleq commented May 11, 2020

or just replace the grid by 2 inputs

That would make the UI nearly useless for anyone using mouse so it's definitely a no-go. The grid is one thing and the inputs are another, and I think what @Comandeer suggested is a very good idea in this case.

@oleq

This comment was marked as off-topic.

@magda-chrzescian

This comment was marked as outdated.

@Reinmar

This comment was marked as outdated.

@oleq

This comment was marked as outdated.

@oleq

This comment was marked as outdated.

@magda-chrzescian

This comment was marked as outdated.

@magda-chrzescian

This comment was marked as outdated.

@martynawierzbicka martynawierzbicka added the support:2 An issue reported by a commercially licensed client. label Aug 31, 2021
@Reinmar Reinmar added the squad:core Issue to be handled by the Core team. label Oct 28, 2021
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@mlewand
Copy link
Contributor

mlewand commented Jun 10, 2022

The column/row count input has been extracted to a dedicated issue #11912 as it's a separate thing.

@mlewand
Copy link
Contributor

mlewand commented Jun 10, 2022

This issue should be solved after we figure out how we want to handle grids in #11851.

Basically the idea here is to treat this grid as any other grid with following exception:

  • As focused / hovered grid item changes the highlight should follow.
  • As focused / hovered grid item changes the column/row number on the bottom should be updated accordingly.

We should also check RTL languages (because in this case the highlighting should go to bottom left corner).

@wimleers
Copy link

FYI: tracking this at https://www.drupal.org/project/drupal/issues/3283801 😊

@mlewand
Copy link
Contributor

mlewand commented Jun 14, 2022

#3184 marked as a (partial) duplicate of this task.

@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Aug 11, 2022
@mmotyczynska mmotyczynska self-assigned this Aug 11, 2022
@mmotyczynska mmotyczynska added squad:features Issue to be handled by the Features team. and removed squad:core Issue to be handled by the Core team. labels Aug 11, 2022
oleq added a commit that referenced this issue Aug 16, 2022
…insert-table-dropdown-grid

Feature (table): Added keyboard support for the table insertion dropdown. Closes #3176.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Aug 16, 2022
@CKEditorBot CKEditorBot added this to the iteration 56 milestone Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:accessibility This issue reports an accessibility problem. package:table squad:features Issue to be handled by the Features team. status:discussion support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

Successfully merging a pull request may close this issue.