-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyboard support for insert table dropdown #3176
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
That would make the UI nearly useless for anyone using mouse so it's definitely a no-go. The grid is one thing and the inputs are another, and I think what @Comandeer suggested is a very good idea in this case. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
The column/row count input has been extracted to a dedicated issue #11912 as it's a separate thing. |
This issue should be solved after we figure out how we want to handle grids in #11851. Basically the idea here is to treat this grid as any other grid with following exception:
We should also check RTL languages (because in this case the highlighting should go to bottom left corner). |
FYI: tracking this at https://www.drupal.org/project/drupal/issues/3283801 😊 |
#3184 marked as a (partial) duplicate of this task. |
…insert-table-dropdown-grid Feature (table): Added keyboard support for the table insertion dropdown. Closes #3176.
While implementing insert table feature:
I've realized that it has no keyboard support defined. But I'd leave it as a followup to focus first on other missing features from MVP.
I also had some minor issues with getting this to work with
FocusCycler
and using<div tabindex="-1">
. Also maybe I'm missing something but with current implementation of above dropdown I'd like to use methods likefocus( 10 )
andfocus( -10 )
to skip a whole row onarrowup
andarrowdown
.For clarity this issue is only about properly handling the keyboard in table dropdown.
The text was updated successfully, but these errors were encountered: