Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to focus balloon toolbars (image toolbar, table toolbar etc) #5146

Closed
jodator opened this issue Apr 19, 2018 · 10 comments · Fixed by #12064
Closed

Unable to focus balloon toolbars (image toolbar, table toolbar etc) #5146

jodator opened this issue Apr 19, 2018 · 10 comments · Fixed by #12064
Assignees
@oleq @mateuszzagorski
Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. package:image squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 56 (v35...

Comments

@jodator
Copy link
Contributor

jodator commented Apr 19, 2018 •
edited by mlewand
Loading

As selected here (sorry for image with text) I'm not able to move focus to a visible baloon toolbar with keyboard.

selection_011

I've tried:

  • ALT+F10 - obviously moves to main toolbar
  • TAB - moves to image caption filed

Same is true for other toolbar like table, media embed etc.

If you'd like to see this feature implemented, add 👍 to this post.
@mlewand
Copy link
Contributor

mlewand commented Jul 24, 2019

Similar fix should be used for fixing (part of) ckeditor/ckeditor5-table#31.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the nice-to-have milestone Oct 9, 2019
@mlewand mlewand added domain:accessibility This issue reports an accessibility problem. module:ux type:bug This issue reports a buggy (incorrect) behavior. package:image labels Oct 9, 2019
@Reinmar Reinmar added domain:ui/ux This issue reports a problem related to UI or UX. and removed module:ux labels Jan 15, 2020
@jodator jodator added the squad:core Issue to be handled by the Core team. label Jul 28, 2020
@Reinmar
Copy link
Member

Reinmar commented Oct 8, 2020

The idea here would be that Alt+F10 could cycle through all possible toolbars (imaga/table/widget, balloon, classic, block, and so on...).

@fhalna
Copy link

fhalna commented Dec 5, 2020

Hello everyone,
Many thanks for the work done for the accessibility of Ckeditor 5, unfortunately this bug related to the possibility of inserting alternatives to images in the editor makes the editor completely inaccessible to blind users.

is it possible to change the milestone of this ticket?

@sunesimonsen
Copy link

It would be nice with a general fix that allows navigating to a contextual toolbar registered with WidgetToolbarRepository.

I would expect Tab to focus the first item and escape to move focus back to the selected editor element.

@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@wimleers
Copy link

FYI: @bramd re-discovered this bug using NVDA at Drupal Dev Days Ghent 2022 — see https://wimleers.com/blog/ddd-ghent-2022 & https://twitter.com/gaborhojtsy/status/1512059083129593858.

The idea here would be that Alt+F10 could cycle through all possible toolbars (imaga/table/widget, balloon, classic, block, and so on...).

This sounds relatively simple to implement I think? If you can give us guidance, maybe we could help make this happen, to address this hard blocker ASAP. 🤞

But it is also not what https://ckeditor.com/docs/ckeditor5/latest/features/keyboard-support.html#user-interface-and-navigation says:

Move focus to the visible contextual balloon: Tab

So … what is the "visible contextual balloon" actually referring to? 🤔

@mlewand mlewand added squad:features Issue to be handled by the Features team. and removed squad:core Issue to be handled by the Core team. labels May 27, 2022
@wimleers wimleers mentioned this issue May 31, 2022
Closed
@mlewand
Copy link
Contributor

mlewand commented Jun 10, 2022 •
edited
Loading

First of all let's make this issue a generic issue for any dynamically added/context toolbar (image toolbar, table toolbar, media embed toolbar etc).

One idea as mentioned is to make one hotkey cycle though all toolbars (good benefit is the discoverability of the feature).

However, let's see if there are any applications out there that have this problem solved so that we can have interoperability with it.

Google docs: it has a context toolbar for images. It can be focused by using ctrl + alt + e, ctrl + alt + p key sequence.

Other WYSIWYG editors use for example ctrl + f9 hotkey to focus balloon toolbar.

Either way we should also check if our toolbars are named correctly (so that the screen reader gives it purpose).

@mlewand mlewand changed the title I'm not able to enter image balloon toolbar by keyboard Unable to focus balloon toolbars (image toolbar, table toolbar etc) Jun 10, 2022
@mlewand mlewand mentioned this issue Jun 10, 2022
Closed
@wimleers
Copy link

Sounds good! 👍

FYI: tracking this at https://www.drupal.org/project/drupal/issues/3283800 😊

@mlewand
Copy link
Contributor

mlewand commented Jun 14, 2022

#3184 marked as a (partial) duplicate of this task.

@jswiderski jswiderski mentioned this issue Jun 24, 2022
Open
@Reinmar Reinmar mentioned this issue Jul 4, 2022
Closed
@oleq oleq mentioned this issue Jul 14, 2022
Merged
24 tasks
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. and removed status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Jul 14, 2022
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jul 28, 2022
@tony1377
Copy link

Any idea roughly when this might make it to release?

@Reinmar
Copy link
Member

Reinmar commented Aug 19, 2022

99% next release (end of August). See #12064

oleq added a commit that referenced this issue Aug 22, 2022
@oleq
Merge pull request #12064 from ckeditor/ck/10368-source-editing-focus…
1499585 
…-toolbar-v2

Feature (core): Enabled toolbar focusing and navigation across various editor implementations and features. Closes #10368. Closes #5146. Closes #9906. Closes #10025.

BREAKING CHANGE (ui): The `enableToolbarKeyboardFocus()` helper has been removed. Please use the [`EditorUI#addToolbar()`](https://ckeditor.com/docs/ckeditor5/latest/api/module_core_editor_editorui-EditorUI.html#function-addToolbar) method instead to enable accessible toolbar navigation (and focusing) using `Alt+F10` and `Esc` keystrokes (see #10368).
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Aug 22, 2022
@CKEditorBot CKEditorBot added this to the iteration 56 milestone Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

@mateuszzagorski mateuszzagorski

Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. package:image squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 56 (v35.1.0)
Development

Successfully merging a pull request may close this issue.

Enabled toolbar focusing and cycling across all editors and features ckeditor/ckeditor5