Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the Document editor build #5886

Closed
Reinmar opened this issue Dec 3, 2019 · 5 comments · Fixed by ckeditor/ckeditor5-build-decoupled-document#32
Closed

Enhance the Document editor build #5886

Reinmar opened this issue Dec 3, 2019 · 5 comments · Fixed by ckeditor/ckeditor5-build-decoupled-document#32
Assignees
@panr
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 29 (v17...

Comments

@Reinmar
Copy link
Member

Reinmar commented Dec 3, 2019 •
edited
Loading

Let's consider replacing the highlight feature with font size and font color.

Let's also consider adding font family.
@Reinmar Reinmar added the type:task This issue reports a chore (non-production change) and other types of "todos". label Dec 3, 2019
@Reinmar
Copy link
Member Author

Reinmar commented Dec 3, 2019

cc @wwalc

@Reinmar Reinmar added this to the iteration 29 milestone Dec 3, 2019
@Reinmar
Copy link
Member Author

Reinmar commented Dec 16, 2019

I can see @wwalc's 👍 so let's do this.

@panr
Copy link
Contributor

panr commented Dec 30, 2019

@Reinmar I need more info about this issue, because I see that Document Build config already has defined font-size and font-family and the only missing piece is the font-color option... 🤔

@jodator
Copy link
Contributor

jodator commented Dec 30, 2019

It looks like this issue is about removing the Highlight feature with FontColor and FontBackgroundColor. I don't recall the intent but adding font color & font background color will make highlight feature in the build obsolete.

Things to check/change:

  1. All mentions about highlight feature in this build (or even writing that we replaced highlight with those two plugins in the build).
  2. Change ckeidtor5-editor-decoupled and ckeditor5-build-decoupled-document (if needed):
    • API docs
    • fremework guide
    • example guide + snippets
    • manual tests (source HTML + configuration)

This was referenced Dec 31, 2019
Merged
Merged
Reinmar added a commit to ckeditor/ckeditor5-build-decoupled-document that referenced this issue Feb 6, 2020
@Reinmar
Merge pull request #32 from ckeditor/i/5886
1f334e3 
Other: Added font color and font background color features and removed the highlight feature. Closes ckeditor/ckeditor5#5886.

MAJOR BREAKING CHANGE: The document editor build does not contain the highlight feature anymore. It was replaced with the font color and font background color features. You should install the highlight feature back in case you expect that the highlight feature was already used by the users of the editor. Otherwise, the markup created in the past by that feature will be filtered out the next time it is loaded to the editor.
@mlewand
Copy link
Contributor

mlewand commented Feb 20, 2020 •
edited
Loading

We also prepared a small plugin that will automatically convert highlight markup to font color/background specific format - preventing potential data loss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@panr panr

Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 29 (v17.0.0)
Development

Successfully merging a pull request may close this issue.

I/5886: Update Decoupled Editor plugin config ckeditor/ckeditor5-build-decoupled-document
4 participants
@Reinmar @jodator @panr @mlewand