Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font color/background UI rendering should be improved #6192

Closed
mlewand opened this issue Feb 4, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-font#60
Closed

Font color/background UI rendering should be improved #6192

mlewand opened this issue Feb 4, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-font#60
Assignees
@mlewand
Labels
package:font package:ui type:improvement This issue reports a possible enhancement of an existing feature. type:performance This issue reports a performance issue or a possible performance improvement.
Milestone
iteration 29 (v17...

Comments

@mlewand
Copy link
Contributor

mlewand commented Feb 4, 2020 •
edited by Reinmar
Loading

📝 Provide detailed reproduction steps (if any)

We should improve rendering time for both foreground and background color dropdowns.

For instance in case of loading editor with short content it took ~126ms and 100ms respectively. That time combined took 28% of entire editor initialization time (editor with small and simple content 220ms was 1.23s).

Profiler flame chart

✔️ Expected result

Faster 🏃‍♀️

❌ Actual result

Slow 🐢

📃 Other details

This is a follow-up of #5880.

  • Browser: Chrome
  • OS: Windows (should be cross system)
  • CKEditor version: latest master

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@mlewand mlewand added package:font package:ui type:performance This issue reports a performance issue or a possible performance improvement. type:improvement This issue reports a possible enhancement of an existing feature. labels Feb 4, 2020
@mlewand mlewand mentioned this issue Feb 5, 2020
Closed
9 tasks
@Reinmar Reinmar added this to the iteration 29 milestone Feb 12, 2020
@mlewand mlewand mentioned this issue Feb 12, 2020
Merged
Reinmar added a commit to ckeditor/ckeditor5-font that referenced this issue Feb 12, 2020
@Reinmar
Merge pull request #60 from ckeditor/i/6192
165417c 
Other: Implemented lazy loading for the font color and background color dropdowns. This will reduce editor initialization time. Closes ckeditor/ckeditor5#6192.
@mlewand mlewand mentioned this issue Feb 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlewand mlewand

Labels
package:font package:ui type:improvement This issue reports a possible enhancement of an existing feature. type:performance This issue reports a performance issue or a possible performance improvement.
Projects
None yet
Milestone
iteration 29 (v17.0.0)
Development

Successfully merging a pull request may close this issue.

Lazy loading for the font color/bg dropdowns ckeditor/ckeditor5-font
2 participants
@Reinmar @mlewand