Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mentions can't have special characters #6398

Closed
fredck opened this issue Mar 10, 2020 · 1 comment · Fixed by ckeditor/ckeditor5-mention#93
Closed

Mentions can't have special characters #6398

fredck opened this issue Mar 10, 2020 · 1 comment · Fixed by ckeditor/ckeditor5-mention#93
Labels
package:mention type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 31 (v19...

Comments

@fredck
Copy link
Contributor

fredck commented Mar 10, 2020

📝 Provide detailed reproduction steps (if any)

  1. Setup an editor with a mentions list containing the entry "+1".
  2. Type your mention marker of choice and then type "+".

✔️ Expected result

The "+1" entry should be the first in the list.

❌ Actual result

No matches found.

📃 Other details

  • CKEditor version: v17.0.0.
  • Installed CKEditor plugins: mention

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@fredck fredck added the type:bug This issue reports a buggy (incorrect) behavior. label Mar 10, 2020
@fredck
Copy link
Contributor Author

fredck commented Mar 10, 2020

In fact, why do we care about limiting the contents of mentions to a specific set of characters? If the user types something that WE consider invalid, the worst it could happen (and totally expected) is that no matches will be found for that, IF the mentions list doesn't really have that character.

@fredck fredck mentioned this issue Mar 10, 2020
Merged
@Mgsy Mgsy added this to the nice-to-have milestone Apr 6, 2020
jodator added a commit to ckeditor/ckeditor5-mention that referenced this issue Apr 16, 2020
@jodator
Merge pull request #93 from ckeditor/t/ckeditor5/6398
aa7d04d 
Other: Mentions can now be matched by any character typed. Closes ckeditor/ckeditor5#6398.
@Reinmar Reinmar modified the milestones: nice-to-have, iteration 31 Apr 20, 2020
@mlewand mlewand mentioned this issue Apr 29, 2020
Closed
mlewand pushed a commit that referenced this issue May 1, 2020
@jodator
Merge pull request #93 from ckeditor/t/ckeditor5/6398
5a0ae52 
Other: Mentions can now be matched by any character typed. Closes #6398.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:mention type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 31 (v19.0.0)
Development

Successfully merging a pull request may close this issue.

Removed restrictions on the type of character allowed to match mentions ckeditor/ckeditor5-mention
3 participants
@Reinmar @fredck @Mgsy