Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing more than 7 rows in a 7 column table crashes editor #6544

Closed
jodator opened this issue Apr 3, 2020 · 3 comments · Fixed by ckeditor/ckeditor5-table#305
Closed

Removing more than 7 rows in a 7 column table crashes editor #6544

jodator opened this issue Apr 3, 2020 · 3 comments · Fixed by ckeditor/ckeditor5-table#305
Assignees
@jodator
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 31 (v19...

Comments

@jodator
Copy link
Contributor

jodator commented Apr 3, 2020

📝 Provide detailed reproduction steps (if any)

Have a table like in the gif below and select more than 7 last rows (see that table have 7 columns, sic!).

✔️ Expected result

Table rows are removed without error.

❌ Actual result

There is an error.

📃 Other details

  • Browser: Chrome/Firefox

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@jodator jodator added type:bug This issue reports a buggy (incorrect) behavior. package:table labels Apr 3, 2020
@jodator jodator added this to the iteration 31 milestone Apr 3, 2020
@jodator jodator self-assigned this Apr 3, 2020
@jodator jodator changed the title Removing more than 7 rows in a 7 column table crasches editor Removing more than 7 rows in a 7 column table crashes editor Apr 3, 2020
@jodator
Copy link
Contributor Author

jodator commented Apr 3, 2020

Check after: #6439. Might be a similar error.

@jodator
Copy link
Contributor Author

jodator commented Apr 15, 2020

It seems that it no longer crashes on master but have bug found in here: ckeditor/ckeditor5-table#305.

@jodator jodator mentioned this issue Apr 15, 2020
Merged
@jodator
Copy link
Contributor Author

jodator commented Apr 17, 2020

Looks like fixed by #6569 or #6437.

@jodator jodator mentioned this issue Apr 17, 2020
Closed
Reinmar added a commit to ckeditor/ckeditor5-table that referenced this issue Apr 17, 2020
@Reinmar
Merge pull request #305 from ckeditor/i/6569
99242fb 
Fix: Resolved various issues with handling bigger tables (due to sorting by indexes issues). Closes ckeditor/ckeditor5#6569. Closes ckeditor/ckeditor5#6544.
mlewand pushed a commit that referenced this issue May 1, 2020
@Reinmar
Merge pull request #305 from ckeditor/i/6569
218ab12 
Fix: Resolved various issues with handling bigger tables (due to sorting by indexes issues). Closes #6569. Closes #6544.
This was referenced Jul 8, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 31 (v19.0.0)
Development

Successfully merging a pull request may close this issue.

I/6569: Remove array sorting flaws from table code ckeditor/ckeditor5-table
1 participant
@jodator