Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Family is not applied correctly inside the editor when used with supportAllValues #7285

Closed
jswiderski opened this issue May 25, 2020 · 0 comments · Fixed by #7367
Closed
Assignees
Labels
package:font support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@jswiderski
Copy link

📝 Provide detailed reproduction steps (if any)

  1. Use the following configuration for your editor
fontFamily: {
            options: [
				'default',
				'Arial,Helvetica,sans-serif',
				'Courier New, Courier, monospace',
				'Georgia, serif',
				'Lucida Sans Unicode, Lucida Grande, sans-serif',
				'Tahoma, Geneva, sans-serif',
				'Times New Roman, serif',
				'Trebuchet MS, Helvetica, sans-serif',
				'Verdana, Geneva, sans-serif',
				'Ubuntu,Arial,sans-serif',
				'Ubuntu Mono, Courier New, Courier,monospace', 
				'Comic Sans MS,Comic Sans MS,cursive'
            ]
	   ,supportAllValues: true
},
  1. Try to apply Ubuntu or Ubuntu Moono font.

✔️ Expected result

Whole font should be applied 'Ubuntu Mono, Courier New, Courier,monospace just like when the above configuration is used without ,supportAllValues: true property.
without

❌ Actual result

Only the first part of font-family is applied, so in case of 'Ubuntu Mono, Courier New, Courier,monospace' this will be only Ubuntu Mono and will have no effect.
supportAllValues

📃 Other details

  • Browser: Any
  • OS: Any
  • CKEditor version: 19.0.0
  • Installed CKEditor plugins: Font

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@jswiderski jswiderski added type:bug This issue reports a buggy (incorrect) behavior. package:font support:2 An issue reported by a commercially licensed client. squad:red labels May 25, 2020
@Reinmar Reinmar added this to the iteration 33 milestone May 26, 2020
@niegowski niegowski self-assigned this Jun 3, 2020
@oleq oleq closed this as completed in #7367 Jun 5, 2020
oleq added a commit that referenced this issue Jun 5, 2020
Fix (font): The Font Family feature should apply the complete family value from the configuration when `config.fontFamily.supportAllValues` is `true`. Closes #7285.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:font support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants