Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog generator does not merge "org/repo#id" issues into single entry #7298

Closed
pomek opened this issue May 27, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-dev#646
Closed

Changelog generator does not merge "org/repo#id" issues into single entry #7298

pomek opened this issue May 27, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-dev#646
Assignees
@pomek
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 33 (v20...

Comments

@pomek
Copy link
Member

pomek commented May 27, 2020

In the latest changelog generated in ckeditor5-dev, Closes reference is duplicated.

Bug fixes
tests: The getRelativeFilePath() util will return proper paths for CKEditor 5 builds. Closes ckeditor/ckeditor5#7280. Closes ckeditor/ckeditor5#7093. (commit)

https://github.com/ckeditor/ckeditor5-dev/blob/master/CHANGELOG.md#bug-fixes

It works fine for #id references:

widget: Brought the feature allowing users to type in tight spots around block widgets where web browsers do not allow the caret to be placed (see #407). Closes #6740, #6688, #6689, #6695. (commit)

https://github.com/ckeditor/ckeditor5/blob/release/CHANGELOG.md#features and dbf24a2.

But, I've just noticed that the mechanism isn't used for multi-entries commits (extracted ones):

paragraph: Implemented the InsertParagraphCommand registered as 'insertParagraph' in the editor. Closes #6823. Closes #7229.

1267018

So we have two bugs to fix:

  1. Closes org/repo#id. Closes org/repo#id2 should be merged into single Closes ...
  2. Apply the mechanism to all entries/commits.
@pomek pomek added type:bug This issue reports a buggy (incorrect) behavior. squad:platform Issue to be handled by the Platform team. package:dev labels May 27, 2020
@pomek pomek added this to the iteration 33 milestone May 27, 2020
@pomek pomek self-assigned this May 27, 2020
@pomek pomek mentioned this issue May 28, 2020
Merged
pomek added a commit to ckeditor/ckeditor5-dev that referenced this issue May 31, 2020
@pomek
Merge pull request #646 from ckeditor/i/7298
4f0737d 
Fix (env): The changelog generator will properly merge the `Closes` references. Closes ckeditor/ckeditor5#7298.

Fix (env): References to issues in additional commits will be merged and linked. See ckeditor/ckeditor5#7298.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomek pomek

Labels
package:dev squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 33 (v20.0.0)
Development

Successfully merging a pull request may close this issue.

Changelog generator will merge "Closes" references in fake commits ckeditor/ckeditor5-dev
1 participant
@pomek