Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should "Release" commit contain [skip ci]? #7302

Closed
pomek opened this issue May 27, 2020 · 1 comment · Fixed by ckeditor/ckeditor5-dev#644
Closed

Should "Release" commit contain [skip ci]? #7302

pomek opened this issue May 27, 2020 · 1 comment · Fixed by ckeditor/ckeditor5-dev#644
Assignees
@pomek
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 33 (v20...

Comments

@pomek
Copy link
Member

pomek commented May 27, 2020

We added it in the past because of CI. After publishing a package and pushing it on GH, CI can require packages in which the release process is still in progress. CI couldn't install the proper version and it ended with an error.

As for now, when we have a single repo, I guess we can remove that and verify the release on CI.

The example release commit: 1ddafcc

cc: @Reinmar, @mlewand
@pomek pomek added type:question This issue asks a question (how to...). squad:platform Issue to be handled by the Platform team. labels May 27, 2020
@Reinmar
Copy link
Member

Reinmar commented May 27, 2020

👍

@pomek pomek mentioned this issue May 27, 2020
Merged
@pomek pomek self-assigned this May 27, 2020
@pomek pomek added this to the iteration 33 milestone May 27, 2020
@pomek pomek added package:dev type:task This issue reports a chore (non-production change) and other types of "todos". and removed type:question This issue asks a question (how to...). labels May 27, 2020
pomek added a commit to ckeditor/ckeditor5-dev that referenced this issue May 31, 2020
@pomek
Merge pull request #644 from ckeditor/i/7302
e3495c8 
Feature (env): Release commit will trigger a Continuous Integration service. Closes ckeditor/ckeditor5#7302.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomek pomek

Labels
package:dev squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 33 (v20.0.0)
Development

Successfully merging a pull request may close this issue.

Release commit will trigger CI ckeditor/ckeditor5-dev
2 participants
@Reinmar @pomek