-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2SCM fails when a link is next to an image (widget) #7437
Labels
Milestone
Comments
pomek
added
type:bug
This issue reports a buggy (incorrect) behavior.
package:link
package:widget
labels
Jun 16, 2020
pomek
changed the title
2SCM fails when a link is next to an image
2SCM fails when a link is next to an image (widget)
Jun 16, 2020
Merged
Reinmar
added a commit
that referenced
this issue
Mar 8, 2021
Feature (engine): Introduced bubbling of `view.Document` events, similar to how bubbling works in the DOM. Bubbling allows listening on a view event on a specific kind of an element, hence simplifying code that needs to handle a specific event for only that element (e.g. `enter` in `blockquote`s only). Read more in the documentation: **\[TODO\]**. Closes #8640. Feature (engine): Introduced `ArrowKeysObserver`. See #8640. Fix (utils): The `EmitterMixin#listenTo()` method is split into listener and emitter parts. The `ObservableMixin` decorated methods reverted to the original method while destroying an observable. Other (typing): The `TwoStepCaretMovement` feature is now using bubbling events. Closes #7437. BREAKING CHANGE: We introduced bubbling of `view.Document` events, similar to how bubbling works in the DOM. That allowed us to reprioritize many listeners that previously had to rely on `priority`. However, it means that existing listeners that use priorities may now be executed in a wrong moment. The listeners to such events should be reviewed in terms of when they should be executed (in what context/element/phase). You can find more information regarding bubbling in the documentation: **\[TODO\]**. See #8640. Internal (widget): The enter, delete and arrow key events handling moved to the usage of the bubbling observer. Internal (block-quote): The enter and delete events handling moved to the usage of the bubbling observer. Internal (code-block): The enter event handling moved to the usage of the bubbling observer. Internal (list): The enter and delete events handling moved to the usage of the bubbling observer. Internal (table): The arrow keys handling moved to the usage of the bubbling observer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📝 Provide detailed reproduction steps (if any)
yarn run manual -f ckeditor5
✔️ Expected result
The selection loses the
linkHref
attribute and I can type after the link.❌ Actual result
The image is selected.
If you'd like to see this fixed sooner, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: