Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Row-spanned cell gets broken down on removing heading section above that cell #7454

Closed
jodator opened this issue Jun 17, 2020 · 0 comments · Fixed by #7572
Closed

Row-spanned cell gets broken down on removing heading section above that cell #7454

jodator opened this issue Jun 17, 2020 · 0 comments · Fixed by #7572
Assignees
@niegowski
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 34 (v21...

Comments

@jodator
Copy link
Contributor

jodator commented Jun 17, 2020

📝 Provide detailed reproduction steps (if any)

  1. Create a table with 1 heading row an a col-spanned cell below heading section.
  2. Remove heading row.

✔️ Expected result

The layout below removed 

❌ Actual result

The cell is broken down before removing changing heading section.

📃 Other details

  • CKEditor version: latest master

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@jodator jodator added type:bug This issue reports a buggy (incorrect) behavior. package:table squad:table labels Jun 17, 2020
@Reinmar Reinmar added this to the iteration 34 milestone Jun 23, 2020
@niegowski niegowski self-assigned this Jul 7, 2020
@jodator jodator mentioned this issue Jul 7, 2020
Closed
niegowski added a commit that referenced this issue Jul 7, 2020
@niegowski
Added test for #7454 issue.
e749264
@niegowski niegowski mentioned this issue Jul 7, 2020
Merged
@jodator jodator mentioned this issue Jul 10, 2020
Closed
jodator added a commit that referenced this issue Jul 10, 2020
@jodator
Merge pull request #7572 from ckeditor/i/7454
8b83c9b 
Fix (table): The table structure should not be changed while removing the heading row. Closes #7454. Closes #7601.

Fix (table): Merging cells of multiple whole rows or columns should not crash the editor.

MINOR BREAKING CHANGE (table): The `removeEmptyRows()` and `removeEmptyRowsColumns()` ulitiy functions does not require `batch` parameter any more.

MINOR BREAKING CHANGE (table): The `downcastTableHeadingRowsChange()` downcast converter has been removed. It is no longer possible to override `headingRows` attribute change in single converter. This behavior can be customized using a table downcast converter. See #7601.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 34 (v21.0.0)
Development

Successfully merging a pull request may close this issue.

#7454: Down-casting whole table on headingRows attribute change ckeditor/ckeditor5
3 participants
@Reinmar @jodator @niegowski