-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After backspacing into a link, the caret should still stay outside #7521
Comments
I'm not sure, though, what should happen if you delete one more letter (one of the link's letters). |
I am having worse problem now #7646 I cannot publish or use this component if this doesn't get fixed (I tried using other builds but ran into bunch of other bugs when integrating plugins). Probably I'll need to get too many likes to get a response.. |
It should stay as today if you leave the link: you delete link but selection does not have a link attribute. |
I've tested the PR solution and I have the same feeling as @oleq - it works nice. However I've found something on master (the "2" below) that troubles me.
So on the above GIF you can see that depending on the selection direction behaves differently - it looks like the link attribute "glues" itself to the selection. It was a surprise for me as my intention was (beside testing the PR 😛 ) to write something in place of the selection. Ps.: when The PR is OK and depending on question 1 - I'm for merging it as it brings value. The "2" can be a follow up. |
@jodator Both concerns are valid in my opinion. They don't block the PR, though, especially that the iteration is about to finish. I think they should become followups and we can address them in the next iteration. |
Fix (link): After backspacing into a link, the caret should still stay outside the link. Closes #7521.
📝 Provide a description of the improvement
So we changed recently (#1016) the behavior when clicking after the link. You will now be placed "outside" the link.
However, the same isn't true when you backspace to that place.
I think we should be consistent here.
If you'd like to see this improvement implemented, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: