Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link should only add highlight class in editing downcast #7614

Closed
Reinmar opened this issue Jul 13, 2020 · 0 comments · Fixed by #7641
Closed

Link should only add highlight class in editing downcast #7614

Reinmar opened this issue Jul 13, 2020 · 0 comments · Fixed by #7641
Assignees
@pomek
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 34 (v21...

Comments

@Reinmar
Copy link
Member

Reinmar commented Jul 13, 2020

📝 Provide detailed reproduction steps (if any)

https://github.com/ckeditor/ckeditor5/blob/df4485f/packages/ckeditor5-link/src/linkui.js#L88-L102

It be should only output in data pipeline.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. squad:blue labels Jul 13, 2020
@Reinmar Reinmar modified the milestones: iteration 34, next Jul 13, 2020
@jodator jodator modified the milestones: next, iteration 34 Jul 15, 2020
@pomek pomek mentioned this issue Jul 17, 2020
Merged
jodator added a commit that referenced this issue Jul 17, 2020
@jodator
Merge pull request #7641 from ckeditor/i/7614
84e2042 
Fix (link): Fake visual selection should not be added to the editor's data. Closes #7614.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomek pomek

Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 34 (v21.0.0)
Development

Successfully merging a pull request may close this issue.

Fake visual selection should not be added to data ckeditor/ckeditor5
3 participants
@Reinmar @jodator @pomek