-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement editing part for List Styles feature #7801
Comments
As for now, I have a basic implementation of the feature. For a bulleted list, you can define a type of marker that will be used when rendering the list. The same applies for numbered lists: And even for nested and mixed lists: However, it's the beginning of problems since the feature must be integrated with other plugins. Indenting listsWhen creating at some point a nested list, it should not inherit the list style attribute/value from the parent list.
However, the deeper structures should not be modified:
Also, it should work correctly when between list items, other nested lists are placed:
The attribute was restored to the default value. However, if
Outdenting listsMore or less it should revert changes made by the A simple scenario:
Don't modify deeper structures:
And copy the value for the
However, the outdent feature can replace the Merging a block to a listA case:
The block item (
or
The later seems to be correct. Fortunately, the first item on the list cannot be nested, so it shouldn't be too hard to implement. In all scenarios, I was considering operations between the same type of lists (all nested lists are bulleted or numbered, but never both at the same time). What in case of mixed lists? As for now, I am treating them as separate elements. |
This comment has been minimized.
This comment has been minimized.
Maybe listening to |
All issues I've spotted are extracted into a separate issue: #7879 |
Feature (list): Introduced the list styles feature that allows customizing the list's marker of the list item elements. Closes #7801. Feature (theme-lark): Creates styles for the `ListStylesUI` plugin (see #7803). MINOR BREAKING CHANGE (ui): It is now possible to override existing components when [adding new ones](https://ckeditor.com/docs/ckeditor5/latest/api/module_ui_componentfactory-ComponentFactory.html#function-add) to the [component factory](https://ckeditor.com/docs/ckeditor5/latest/api/module_ui_componentfactory-ComponentFactory.html) (previously an error was thrown) (see #7803).
Part of #1031.
The text was updated successfully, but these errors were encountered: