Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the label for the "Insert image via URL" form change #7878

Closed
panr opened this issue Aug 19, 2020 · 1 comment · Fixed by #7960
Closed

Should the label for the "Insert image via URL" form change #7878

panr opened this issue Aug 19, 2020 · 1 comment · Fixed by #7960
Assignees
@panr
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:image squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 36 (v23...

Comments

@panr
Copy link
Contributor

panr commented Aug 19, 2020

📝 Provide a description of the improvement

We can consider if the label for the form should change to Update image via URL, when the user selects the image in the content and then opens the dropdown (the form input is filled).

ATM, in that scenario, only the submit button will change, from Insert to Update. The label for the Insert image via URL is static (doesn't change).

image

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@panr panr added type:improvement This issue reports a possible enhancement of an existing feature. package:image domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. labels Aug 19, 2020
@panr panr added this to the next milestone Aug 19, 2020
@oleq
Copy link
Member

oleq commented Aug 20, 2020

Sounds like a good idea. But maybe "Update image URL" instead of "Update image via URL"?

@Reinmar Reinmar modified the milestones: next, iteration 36 Aug 26, 2020
@panr panr self-assigned this Aug 27, 2020
@panr panr mentioned this issue Aug 28, 2020
Merged
oleq added a commit that referenced this issue Aug 31, 2020
@oleq
Merge pull request #7960 from ckeditor/i/7878
288fb97 
Other (image): The `ImageUploadPanelView` form label should change depending on whether the image is selected or not. Closes #7878.

Internal (image): Added the new `ImageUploadPanelView#getIntegration()` method to pick a desired integration by name from the collection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@panr panr

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:image squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 36 (v23.0.0)
3 participants
@Reinmar @oleq @panr