Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve import linter error mesage #8245

Closed
mlewand opened this issue Oct 12, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-dev#675
Closed

Improve import linter error mesage #8245

mlewand opened this issue Oct 12, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-dev#675
Assignees
@psmyrek
Labels
intro Good first ticket. squad:platform Issue to be handled by the Platform team. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@mlewand
Copy link
Contributor

mlewand commented Oct 12, 2020

📝 Provide a description of the improvement

Currently the linter shows a following error like:

57.84sChecking dependencies...
Found some issue with dependencies.
Invalid itself imports:
- tests/manual/tickets/4600/1.js
💥 engine have a dependency problem 💥

That's enough if you're working in the project and remember what it is about. However it should provide enough information to understand how the problem should be fixed.

Either a short message like "Imports from local package must use relative path." or a link where the problem is explained.

Based on https://travis-ci.org/github/ckeditor/ckeditor5/builds/734972961

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@mlewand mlewand added type:improvement This issue reports a possible enhancement of an existing feature. squad:dx intro Good first ticket. labels Oct 12, 2020
@Reinmar Reinmar added squad:platform Issue to be handled by the Platform team. and removed squad:dx labels Oct 15, 2020
@psmyrek psmyrek mentioned this issue Oct 21, 2020
Merged
pomek added a commit to ckeditor/ckeditor5-dev that referenced this issue Oct 21, 2020
@pomek
Merge pull request #675 from ckeditor/i/8245
bbb5495 
Other (tests): Improved linter error message for self-imports. Closes ckeditor/ckeditor5#8245.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psmyrek psmyrek

Labels
intro Good first ticket. squad:platform Issue to be handled by the Platform team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve self import linter error mesage ckeditor/ckeditor5-dev
3 participants
@Reinmar @mlewand @psmyrek