Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing features to the all-features manual test #8317

Closed
pomek opened this issue Oct 22, 2020 · 2 comments · Fixed by #8441
Closed

Add missing features to the all-features manual test #8317

pomek opened this issue Oct 22, 2020 · 2 comments · Fixed by #8441
Assignees
@psmyrek
Labels
intro Good first ticket. squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 38 (v24...

Comments

@pomek
Copy link
Member

pomek commented Oct 22, 2020 •
edited
Loading

http://localhost:8125/ckeditor5/tests/manual/all-features.html

Missing features:

  • HTML Embed
  • List styles
  • Paste from Office

Would be good for having those all here.
@pomek pomek added type:task This issue reports a chore (non-production change) and other types of "todos". intro Good first ticket. squad:platform Issue to be handled by the Platform team. labels Oct 22, 2020
@pomek pomek modified the milestones: nice-to-have, iteration 38 Oct 22, 2020
@pomek pomek changed the title Add html-embed to all-features manual test Add missing features to the all-features manual test Oct 29, 2020
@pomek
Copy link
Member Author

pomek commented Oct 29, 2020

I updated the ticket title and body.
More features could be added and I mention some of them in the first post. I could miss something, so feel free to add it if missing.

@psmyrek
Copy link
Contributor

psmyrek commented Nov 9, 2020

There is probably a bug in ImageResize plugin used together with HtmlEmbed plugin which has showPreviews option set to true - see #8433.

@psmyrek psmyrek mentioned this issue Nov 10, 2020
Merged
pomek added a commit that referenced this issue Nov 10, 2020
@pomek
Merge pull request #8441 from ckeditor/i/8317
2c52fb2 
Tests: Added new plugins to the `all-features` manual test: `HtmlEmbed`, `ListStyle` and `PasteFromOffice`. Closes #8317.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psmyrek psmyrek

Labels
intro Good first ticket. squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 38 (v24.0.0)
Development

Successfully merging a pull request may close this issue.

Added missing plugins to the all-features manual test ckeditor/ckeditor5
2 participants
@pomek @psmyrek