Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The editing root should remain focused when saving changes in the embed #8318

Closed
oleq opened this issue Oct 22, 2020 · 2 comments · Fixed by #8415
Closed

The editing root should remain focused when saving changes in the embed #8318

oleq opened this issue Oct 22, 2020 · 2 comments · Fixed by #8415
Assignees
@pkwasnik
Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:html-embed squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 38 (v24...

Comments

@oleq
Copy link
Member

oleq commented Oct 22, 2020 •
edited
Loading

📝 Provide detailed reproduction steps (if any)

  1. Run an editor with a dynamic toolbar (inline, balloon) in http://fake.ckeditor.com:8125/ckeditor5-html-embed/tests/manual/htmlembed.html.
  2. Edit an embed.
  3. Save it.

✔️ Expected result

Widget is focused. The editor is focused. The toolbar remains visible.

❌ Actual result

The editor loses focus. The global toolbar disappears.

📃 Other details

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. intro Good first ticket. domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. package:html-embed labels Oct 22, 2020
@Reinmar Reinmar added this to the nice-to-have milestone Oct 22, 2020
@Reinmar Reinmar added the domain:accessibility This issue reports an accessibility problem. label Oct 26, 2020
@AnnaTomanek AnnaTomanek modified the milestones: nice-to-have, iteration 38 Oct 26, 2020
@pkwasnik pkwasnik self-assigned this Nov 3, 2020
@pkwasnik
Copy link
Contributor

pkwasnik commented Nov 3, 2020 •
edited
Loading

@oleq If the editor stays focused after save, how a user could close it to see the preview? Currently "cancel" button undo all changes even if clicked after "save". Should I modfy "cancel" behaviour or maybe you have another solution?

@oleq
Copy link
Member Author

oleq commented Nov 4, 2020

"Save" accepts the changes. "Cancel" discards them. Regardless of which one is clicked in the end, the editor (view root) should remain focused and the widget should also be selected (if selected before clicking "Edit").

@pkwasnik pkwasnik mentioned this issue Nov 4, 2020
Merged
jodator added a commit that referenced this issue Nov 5, 2020
@jodator
Merge pull request #8415 from ckeditor/i/8318
2d8207a 
Fix (html-embed): The editing root should remain focused when saving changes in the HTML embed widget. Closes #8318.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkwasnik pkwasnik

Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:html-embed squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 38 (v24.0.0)
Development

Successfully merging a pull request may close this issue.

The editing root should remain focused when saving changes in the embed ckeditor/ckeditor5
4 participants
@Reinmar @AnnaTomanek @oleq @pkwasnik