Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Safari@iOS] The previewless raw html text has too low contrast #8320

Closed
oleq opened this issue Oct 22, 2020 · 1 comment · Fixed by #8818
Closed

[Safari@iOS] The previewless raw html text has too low contrast #8320

oleq opened this issue Oct 22, 2020 · 1 comment · Fixed by #8818
Assignees
@magda-chrzescian
Labels
domain:mobile This issues reports a problem related to a mobile environment. domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:html-embed squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 39 (v25...

Comments

@oleq
Copy link
Member

oleq commented Oct 22, 2020

📝 Provide detailed reproduction steps (if any)

  1. Go to http://fake.ckeditor.com/ck/5/ckeditor5/build/docs/ckeditor5/latest/features/html-embed.html.
  2. Disable previews.

✔️ Expected result

In Chrome on Mac:

❌ Actual result

Safari in iOS:

📃 Other details

  • Browser: …
  • OS: …
  • CKEditor version: …
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. domain:ui/ux This issue reports a problem related to UI or UX. domain:mobile This issues reports a problem related to a mobile environment. squad:core Issue to be handled by the Core team. package:html-embed labels Oct 22, 2020
@Reinmar
Copy link
Member

Reinmar commented Oct 22, 2020

Actually, is the contrast on desktop high enough? It's quite low too.

@Mgsy Mgsy added this to the nice-to-have milestone Oct 26, 2020
@oleq oleq added the intro Good first ticket. label Dec 7, 2020
@magda-chrzescian magda-chrzescian self-assigned this Jan 12, 2021
@magda-chrzescian magda-chrzescian mentioned this issue Jan 12, 2021
Merged
oleq added a commit that referenced this issue Jan 14, 2021
@oleq
Merge pull request #8818 from ckeditor/i/8320-HTML-low-contrast
521847c 
Fix (theme-lark): The HTML embed text in a disabled input in Safari on iOS should have the same color as in other browsers. Closes #8320.
@oleq oleq modified the milestones: nice-to-have, iteration 39 Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magda-chrzescian magda-chrzescian

Labels
domain:mobile This issues reports a problem related to a mobile environment. domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:html-embed squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 39 (v25.0.0)
Development

Successfully merging a pull request may close this issue.

Overriding Safari's disabled input opacity. ckeditor/ckeditor5
4 participants
@Reinmar @oleq @magda-chrzescian @Mgsy