Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline images - Feature guide #8591

Closed
pkwasnik opened this issue Dec 6, 2020 · 5 comments
Closed

Inline images - Feature guide #8591

pkwasnik opened this issue Dec 6, 2020 · 5 comments
Assignees
@oleq @magda-chrzescian @godai78
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:easy-image squad:core Issue to be handled by the Core team. type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Milestone
iteration 44 (v29...

Comments

@pkwasnik
Copy link
Contributor

pkwasnik commented Dec 6, 2020 •
edited
Loading

Create a feature guide for inline images.
Add a mention in the image guide.
@pkwasnik pkwasnik self-assigned this Dec 6, 2020
@pkwasnik pkwasnik added package:image type:docs This issue reports a task related to documentation (e.g. an idea for a guide). domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. labels Dec 6, 2020
@Reinmar Reinmar added this to the nice-to-have milestone Dec 7, 2020
@pkwasnik pkwasnik changed the title Inline images - documenting Inline images - feature guide Dec 20, 2020
@pkwasnik pkwasnik changed the title Inline images - feature guide Inline images - Feature guide Dec 21, 2020
@pkwasnik pkwasnik removed their assignment Dec 21, 2020
@magda-chrzescian
Copy link
Contributor

magda-chrzescian commented Mar 2, 2021 •
edited
Loading

Might be worth mentioning in the guide, that the image style class will be applied to a different element in the editor view and the HTML output. More in this comment: #8775 (comment)

@oleq oleq mentioned this issue Mar 17, 2021
Closed
@oleq
Copy link
Member

oleq commented Mar 23, 2021

#9339 is one of the pieces.

@zrpnr zrpnr mentioned this issue Mar 25, 2021
Draft
@magda-chrzescian
Copy link
Contributor

When you use EasyImage and load either ImageBlock or ImageInline (but not Image) there is a soft requirement error in the console because Image is missing.

The code of the EasyImage plugin does not use anything from @ckeditor/ckeditor5-image so this is a virtual requirement. Most likely we made Image the requirement of EasyImage to improve DX so developers don't have to include both if they want to use our service. The intention was good but it backfired when the API has changed.

The solution is getting rid of the requirement (breaking change) and mentioning in the migration guide that EasyImage must be used together with Image.

@AnnaTomanek AnnaTomanek modified the milestones: nice-to-have, iteration 43 Apr 19, 2021
@oleq oleq self-assigned this May 6, 2021
@oleq oleq mentioned this issue May 10, 2021
Merged
10 tasks
@AnnaTomanek AnnaTomanek mentioned this issue May 28, 2021
Closed
@oleq oleq mentioned this issue Jun 1, 2021
Closed
11 tasks
@oleq
Copy link
Member

oleq commented Jun 1, 2021

This task will be continued in #8591.

oleq added a commit that referenced this issue Jun 1, 2021
@oleq
Merge pull request #9656 from ckeditor/i/8591-inline-images-guide
55b86f8 
Docs: Inline images guide. Closes #8591.
@oleq
Copy link
Member

oleq commented Jun 1, 2021

Closed in #9656.

@oleq oleq closed this as completed Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

@magda-chrzescian magda-chrzescian

@godai78 godai78

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:easy-image squad:core Issue to be handled by the Core team. type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Projects
None yet
Milestone
iteration 44 (v29.0.0)
Development

No branches or pull requests
6 participants
@Reinmar @AnnaTomanek @oleq @magda-chrzescian @pkwasnik @godai78