Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong package was marked as "minor release" #8596

Closed
pomek opened this issue Dec 7, 2020 · 1 comment · Fixed by ckeditor/ckeditor5-dev#686
Closed

Wrong package was marked as "minor release" #8596

pomek opened this issue Dec 7, 2020 · 1 comment · Fixed by ckeditor/ckeditor5-dev#686
Assignees
Labels
package:dev squad:devops Issue to be handled by the Devops team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@pomek
Copy link
Member

pomek commented Dec 7, 2020

📝 Provide detailed reproduction steps (if any)

In the latest changelog (24.0.0) I found this:

Minor releases (contain minor breaking changes):

@ckeditor/ckeditor5-easy-image: v23.1.0 => v24.0.0

I was surprised.

git log --name-status -10 packages/ckeditor5-easy-image/

All last changes modified the package.json file (bump version). There was no change in the package.

Something wrong goes here – https://github.com/ckeditor/ckeditor5-dev/blob/36d75fef2e65e546397e93bcb7f4c610a542d945/packages/ckeditor5-dev-env/lib/release-tools/tasks/generatechangelogformonorepository.js#L495-L500

✔️ Expected result

Minor releases (contain minor breaking changes):

* [@ckeditor/ckeditor5-image](https://www.npmjs.com/package/@ckeditor/ckeditor5-image): v23.1.0 => v24.0.0

❌ Actual result

Minor releases (contain minor breaking changes):

* [@ckeditor/ckeditor5-easy-image](https://www.npmjs.com/package/@ckeditor/ckeditor5-easy-image): v23.1.0 => v24.0.0
* [@ckeditor/ckeditor5-image](https://www.npmjs.com/package/@ckeditor/ckeditor5-image): v23.1.0 => v24.0.0

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@pomek pomek added type:bug This issue reports a buggy (incorrect) behavior. squad:devops Issue to be handled by the Devops team. labels Dec 7, 2020
@pomek pomek added this to the iteration 39 milestone Dec 7, 2020
@pomek pomek self-assigned this Dec 7, 2020
@pomek pomek removed their assignment Dec 11, 2020
@pomek
Copy link
Member Author

pomek commented Jan 11, 2021

I guess, replacing the code in the link above with:

for ( const [ packageName, version ] of dependencies ) {
	const packageScope = packageName.replace( /^@ckeditor\/ckeditor5?-/, '' );

	  for ( const singleScope of scopes ) {
		  if ( packageScope === singleScope ) {
			  packages.set( packageName, version );
			  dependencies.delete( packageName );
		  }
	  }
}

Should be enough.

@pomek pomek self-assigned this Jan 11, 2021
mlewand added a commit to ckeditor/ckeditor5-dev that referenced this issue Jan 12, 2021
…d properly by exact comparing their scopes instead of matching values. Closes ckeditor/ckeditor5#8596.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:dev squad:devops Issue to be handled by the Devops team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant