Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inner shadow inside border dropdown in table cell properties balloon #8699

Closed
niegowski opened this issue Dec 16, 2020 · 0 comments · Fixed by #8761
Closed

Inner shadow inside border dropdown in table cell properties balloon #8699

niegowski opened this issue Dec 16, 2020 · 0 comments · Fixed by #8761
Assignees
@magda-chrzescian
Labels
intro Good first ticket. package:theme-lark type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 39 (v25...

Comments

@niegowski
Copy link
Contributor

📝 Provide detailed reproduction steps (if any)

  1. https://ckeditor.com/docs/ckeditor5/latest/features/table.html
  2. Open table cell properties balloon
  3. Click Border Style dropdown

✔️ Expected result

No inner shadow.

❌ Actual result

An inner shadow appears (animates while pressing).

📃 Other details

  • Browser: …
  • OS: …
  • CKEditor version: …
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@niegowski niegowski added type:bug This issue reports a buggy (incorrect) behavior. squad:core Issue to be handled by the Core team. labels Dec 16, 2020
@oleq oleq added intro Good first ticket. package:theme-lark and removed squad:core Issue to be handled by the Core team. labels Dec 21, 2020
@oleq oleq added this to the iteration 39 milestone Jan 4, 2021
@magda-chrzescian magda-chrzescian mentioned this issue Jan 7, 2021
Merged
oleq added a commit that referenced this issue Jan 12, 2021
@oleq
Merge pull request #8761 from ckeditor/i/8699-dropdown-shadow
395d954 
Fix (theme-lark): The dropdown button should not have an inner shadow in the active state. Closes #8699.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magda-chrzescian magda-chrzescian

Labels
intro Good first ticket. package:theme-lark type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 39 (v25.0.0)
Development

Successfully merging a pull request may close this issue.

Removed inner shadow for active drop-downs. ckeditor/ckeditor5
3 participants
@oleq @niegowski @magda-chrzescian