insertImage should be enabled by default in all builds #870

wwalc · 2018-03-02T11:16:03Z

I think it will be confusing for end users that there is no image button in the toolbar. The discoverability of image support is close to zero in an editor that does not have any content with images inside already. Which, unlike on our demo pages, is the reality. After all when you create content you most of the time start with an empty editor.

Even GitHub, being a developer-oriented environment provides a hint for end users on how to upload images:

Having no UI that suggests that images can be uploaded is confusing, IMO.

WDYT?

Reinmar · 2018-03-02T12:23:51Z

Adding this button to the toolbar by default sounds like a good idea. We've seen enough confusion already.

Where would you place this button (I mean the buttons order)?

Reinmar · 2018-03-02T12:24:15Z

cc @oleq

wwalc · 2018-03-02T13:10:18Z

Where would you place this button (I mean the buttons order)?

I don't have any strong preferences here, apart from wishing to have the link and insertImage buttons close to each other (they both are frequently used and "insert" something).

Current

items: [
	'headings',
	'|',
	'bold',
	'italic',
	'link',
	'bulletedList',
	'numberedList',
	'blockQuote',
	'undo',
	'redo'
]

Proposal

items: [
	'headings',
	'|',
	'bold',
	'italic',
	'bulletedList',
	'numberedList',
	'link',
	'insertImage',
	'blockQuote',
	'undo',
	'redo'
]

My reasoning: from basic features and frequently used to less frequently used (I have not stats, just intuition and own experience)

Reinmar · 2018-03-05T11:00:48Z

cc @oleq WDYT?

oleq · 2018-03-05T11:03:47Z

LGTM. I'll check it live and give you the feedback ASAP.

oleq · 2018-03-05T14:12:51Z

It looks as follows

We could also go ocdish

but the first one LGTM.

@wwalc s/insertImage/uploadImage/?

Reinmar · 2018-03-05T14:57:07Z

@wwalc s/insertImage/uploadImage/?

The name of the button was changed in this iteration. It was insertImage previously, but it's actually completely upload-oriented, so we decided to keep it consistent with that so we can propose insertImage with a wider range of options in the future.

…ditor5#870.

Reinmar · 2018-03-12T10:14:05Z

Closed with:

* Feature: Added the image upload button to the build. See ckeditor/ckeditor5#870. * Internal: Build. * Internal: Build. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v1.0.0-beta.1. * Internal: Updated links to CKEditor 5 website. [skip ci] * Docs: Typo in README fixed. [skip ci] * Removed duplicated "ImageUpload" plugin. * Internal: Updated dependencies. * Tests: Added manual tests for translating editors. See ckeditor/ckeditor5#914. * Internal: Build. * Internal: Build. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v1.0.0-beta.2. * Fix: Translations should work when CKEditor was loaded using RequireJS. See ckeditor/ckeditor5-dev#914. * Internal: Build. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Build. * Release: v1.0.0-beta.3. * Docs: Fixed link in the readme. [skip ci] * Docs: Mentioned previous release in the changelog. [skip ci] * Internal: Updated keywords. [skip ci] * Internal: Build. * Internal: Fixed keywords. [skip ci] * Internal: Improved license file. * Docs: Changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v1.0.0-beta.4. * Other: Changed the license to GPL2+ only. See ckeditor/ckeditor5#991. BREAKING CHANGE: The license under which CKEditor 5 is released has been changed from a triple GPL, LGPL and MPL license to a GPL2+ only. See ckeditor/ckeditor5#991 for more information. * Internal: Updated dependencies. * Internal: Build. * Docs: Changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v10.0.0. * Docs: Changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v10.0.1. * Adjusted code to the changes in ckeditor5-editor-classic. * Internal: Build. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Build. * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v10.1.0. * Switched to webpack@4.12 and UglifyJsWebpackPlugin. * Switched back to banner with exclamation mark. * Webpack up. * Bump, bump. * Hide unnecessary warnings. * Improved comments. * Internal: Upgraded version of Node.js. See ckeditor/ckeditor5-dev#417. * Docs: Improved the package description. * Docs: Improved keywords and the readme. [skip ci] * Internal: Aligned code to changes in ckeditor5-core. See ckeditor/ckeditor5-core#140. * Internal: Build. * Other: Changed the build structure. TODO. Closes ckeditor/ckeditor5#1038. * Internal: Build. * Internal: Build. * Internal: Build. * Internal: Build. * Internal: Build. * Removed unnecessary comment in `webpack.config.js`. * Internal: Further builds simplifications plus some comments. * Internal: Build. * Internal: Build. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v11.0.0. * Internal: Build. * Internal: Build. * Docs: Changelog. [skip ci] * Internal: Build. * Release: v11.0.1. * Docs: Changed links to documentation. See ckeditor/ckeditor5#1192. * Internal: Upgraded dependencies. * Docs: Changed links to documentation. See ckeditor/ckeditor5#1192. * Upgraded version of ESLint. * Added build screenshot to README.md. * Added Media Embed and Table features to the build. * Internal: Build. * Tests: Updated build tests to the new toolbar configuration. * Internal: Build. * That option got renamed in the meantime. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v11.1.0. [skip ci] * Docs: Fixed invalid merge in the readme. * Docs: Changelog. [skip ci] * Internal: Build. * Release: v11.1.1. [skip ci] * Docs: Made contributing guide link to our docs. [skip ci] * Feature: Introduced the Paste From Office feature. * Feature: Introduced the CKFinder integration plugin. * Internal: Build. * Internal: Build. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v11.2.0. [skip ci] * Introduced a linter and Travis. * Added a configuration for ESLint. * Directory created by Mgit on CI must be ignored as well. * Code style in tests. * Update raw-loader dependency. * Aligned Travis configuration after switching to Yarn. See ckeditor/ckeditor5#1214. * Docs: Added build status badges to the README. See: ckeditor/ckeditor5#1236. * Fixed formatting in Travis configuration file. * Updated deps. * Add memory leak test. * Add missing ckeditor5-core dependency. * Internal: Bumped the year. [skip ci] * Upgraded version of husky. * Other: Upgraded minimal versions of Node and npm. See: ckeditor/ckeditor5#1507. * Internal: Updated deps. * Internal: Build. * Internal: Build. * Docs: Updated the homepage link. [skip ci] * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v12.0.0. [skip ci] * Internal: Removed unnecessary and added missing deps. * Internal: Introduced Slack Notifications for this repository on CI. * Internal: Build. * Internal: Build. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v12.1.0. [skip ci] * Internal: Changed a way how to install Chrome on Travis. [skip ci] * Internal: Updated the license header. See ckeditor/ckeditor5#1557. [skip ci] * Internal: Build. * Internal: Updated license section in README. See ckeditor/ckeditor5#1557. [skip ci] * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v12.2.0. [skip ci] * Removed BrowserStack from the repository. * Internal: Build. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v12.3.0. [skip ci] * Internal: Ping CI. * Internal: Bumped up deps. * Internal: Build. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v12.3.1. [skip ci] * All tests require an image that exists. It will not cause the 404 error. * Bumped style-loader to v1.0.0. Aligned the webpack config to the new loader API. * Bumped up raw-loader, uglifyjs-webpack-plugin, webpack, and webpack-cli dependencies. * Internal: Build. * Internal: Build. * Other: Changed the URL under bugs key in package.json file. Now we have one issue tracker. See ckeditor/ckeditor5#1988. * Internal: Build. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v12.4.0. [skip ci] * Internal: Make CI green. * Docs: Removed gitter badge. See ckeditor/ckeditor5#2037. [skip ci] * Internal: Upgraded CI environment to use Xenial version of the distro. See ckeditor/ckeditor#2041. * Feature: Enabled the indent feature in the build. * Internal: Build. * Tests: Updated the test. * Internal: Build. * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v15.0.0. [skip ci] * Internal: Make CI green. * Internal: Updated the GitHub PR template because all packages share the same issue tracker now (see ckeditor/ckeditor5#5576). * Internal: Enabled stylelint in the package. * Internal: Allowed empty input in the stylelint script to avoid errors when no files are found. Added missing stylelint-config-recommended dependency. * Internal: Added the stylelintrc config. [skip ci] * Used the external stylelint-config-ckeditor5 package for stylelint configuration. * Replaced UglifyJS with Terser. * Internal: Build. * Internal: Added a missing pacakge dev-dependencies. See ckeditor/ckeditor5#5856. * Internal: Made the error initialization catch statements more informative. * Minor improvements to error messages used in manual tests and a sample. [skip ci] * Docs: Changelog. [skip ci] * Docs: Corrected the changelog. [skip ci] * Internal: Updated dependencies. [skip ci] * Internal: Build. * Release: v16.0.0. [skip ci] * Internal: Make CI green. * Internal: Added blog post URL. [skip ci] * Internal: Fixed blog post URL for the 11.0.0 release. [skip ci] * Internal: Added config for package.json to .editorconfig. See #318. * Internal: Bumped the year. [skip ci] Co-authored-by: Piotrek Koszuliński <pkoszulinski@gmail.com> Co-authored-by: Kamil Piechaczek <pomek@users.noreply.github.com> Co-authored-by: Anna Tomanek <a.tomanek@cksource.com> Co-authored-by: Maciej Bukowski <ma2ciek@gmail.com> Co-authored-by: Aleksander Nowodzinski <a.nowodzinski@cksource.com> Co-authored-by: Damian Konopka <dk@damiankonopka.pl> Co-authored-by: Maciej <jodator@jodator.net> Co-authored-by: Marek Lewandowski <mlewand@users.noreply.github.com>

…ditor5#870.

Reinmar added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". labels Mar 2, 2018

Reinmar added this to the iteration 14 milestone Mar 2, 2018

Reinmar self-assigned this Mar 8, 2018

Reinmar added a commit to ckeditor/ckeditor5-build-classic that referenced this issue Mar 12, 2018

Feature: Added the image upload button to the build. See ckeditor/cke…

f6cab12

…ditor5#870.

Reinmar added a commit to ckeditor/ckeditor5-build-inline that referenced this issue Mar 12, 2018

Feature: Added the image upload button to the build. See ckeditor/cke…

67e0779

…ditor5#870.

Reinmar added a commit to ckeditor/ckeditor5-build-balloon that referenced this issue Mar 12, 2018

Feature: Added the image upload button to the build. See ckeditor/cke…

a1f9451

…ditor5#870.

Reinmar closed this as completed Mar 12, 2018

JDinABox pushed a commit to JDinABox/ckeditor5-build-markdown that referenced this issue Sep 6, 2021

Feature: Added the image upload button to the build. See ckeditor/cke…

7fdc3b9

…ditor5#870.

rivernews pushed a commit to rivernews/ckeditor5-build-balloon-2022 that referenced this issue Dec 31, 2021

Feature: Added the image upload button to the build. See ckeditor/cke…

66152dc

…ditor5#870.

fl01337 pushed a commit to fl01337/ckeditor-5-build-inline that referenced this issue May 19, 2022

Feature: Added the image upload button to the build. See ckeditor/cke…

925545e

…ditor5#870.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

insertImage should be enabled by default in all builds #870

insertImage should be enabled by default in all builds #870

wwalc commented Mar 2, 2018 •

edited

Loading

Reinmar commented Mar 2, 2018

Reinmar commented Mar 2, 2018

wwalc commented Mar 2, 2018

Reinmar commented Mar 5, 2018

oleq commented Mar 5, 2018

oleq commented Mar 5, 2018

Reinmar commented Mar 5, 2018

Reinmar commented Mar 12, 2018

insertImage should be enabled by default in all builds #870

insertImage should be enabled by default in all builds #870

Comments

wwalc commented Mar 2, 2018 • edited Loading

Reinmar commented Mar 2, 2018

Reinmar commented Mar 2, 2018

wwalc commented Mar 2, 2018

Current

Proposal

Reinmar commented Mar 5, 2018

oleq commented Mar 5, 2018

oleq commented Mar 5, 2018

Reinmar commented Mar 5, 2018

Reinmar commented Mar 12, 2018

wwalc commented Mar 2, 2018 •

edited

Loading