Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to select HTML embed when no other widget plugins are installed #8720

Closed
LukaszGudel opened this issue Dec 23, 2020 · 1 comment · Fixed by #8760
Closed

Unable to select HTML embed when no other widget plugins are installed #8720

LukaszGudel opened this issue Dec 23, 2020 · 1 comment · Fixed by #8760
Assignees
@magda-chrzescian
Labels
intro Good first ticket. package:html-embed squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 39 (v25...

Comments

@LukaszGudel
Copy link
Contributor

LukaszGudel commented Dec 23, 2020 •
edited
Loading

📝 Provide detailed reproduction steps (if any)

  1. Configure online build with plugins: Bold, Italic, List, Link, HTML Embed
  2. Open sample.html
  3. Add html embed and try to select it

✔️ Expected result

HTML snippet is selected and there are icons to add a paragraph before and after the element.

❌ Actual result

Unable to select HTML snippet.

📃 Other details

  • Browser: any
  • OS: macOS BigSur 11.1
  • CKEditor version: 24.0.0
  • Installed CKEditor plugins: Bold, Essentials, Italic, Link, HtmlEmbed, Paragraph
  • If I add Table or Image or Media Embed plugin to my build then HTMLEmbed is selected correctly

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@LukaszGudel LukaszGudel added type:bug This issue reports a buggy (incorrect) behavior. squad:core Issue to be handled by the Core team. package:html-embed labels Dec 23, 2020
@Reinmar
Copy link
Member

Reinmar commented Jan 4, 2021

It's missing the Widget plugin in its deps. Compare to e.g. MediaEmbed.

@Reinmar Reinmar added this to the nice-to-have milestone Jan 4, 2021
@Reinmar Reinmar added the intro Good first ticket. label Jan 4, 2021
@oleq oleq modified the milestones: nice-to-have, iteration 39 Jan 4, 2021
@magda-chrzescian magda-chrzescian mentioned this issue Jan 7, 2021
Merged
oleq added a commit that referenced this issue Jan 11, 2021
@oleq
Merge pull request #8760 from ckeditor/i/8720-html-embed-widget
8ef02e7 
Fix (html-embed): The HTML embed plugin should require the `Widget` plugin. Closes #8720.
@oleq oleq mentioned this issue Jan 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magda-chrzescian magda-chrzescian

Labels
intro Good first ticket. package:html-embed squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 39 (v25.0.0)
Development

Successfully merging a pull request may close this issue.

Widget required in html-embed plugin. ckeditor/ckeditor5
4 participants
@Reinmar @oleq @magda-chrzescian @LukaszGudel