Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor crashes after pasting double-commented text in a bulleted list from MS Word #9954

Closed
Mgsy opened this issue Jun 25, 2021 · 3 comments · Fixed by #10084
Closed

Editor crashes after pasting double-commented text in a bulleted list from MS Word #9954

Mgsy opened this issue Jun 25, 2021 · 3 comments · Fixed by #10084
Assignees
Labels
package:paste-from-office squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.

Comments

@Mgsy
Copy link
Member

Mgsy commented Jun 25, 2021

📝 Provide detailed reproduction steps (if any)

  1. In MS Word create a new bulleted list with one item.
  2. Type something.
  3. Select the text, right-click on it and add a comment.
  4. Repeat step 3.
  5. Select all and copy.
  6. Paste it to https://ckeditor.com/docs/ckeditor5/latest/features/pasting/paste-from-word.html#demo.

✔️ Expected result

The content pastes.

❌ Actual result

The editor crashes.

📃 Other details

It's a regression introduced in v24.0.0.

Error

list.js:235 Uncaught TypeError: Cannot read property 'is' of undefined
    at findListMarkerNode (list.js:235)
    at findBulletedListStyle (list.js:202)
    at detectListStyle (list.js:183)
    at list.js:49
    at Array.forEach (<anonymous>)
    at transformListItemLikeElementsIntoLists (list.js:38)
    at MSWordNormalizer.execute (mswordnormalizer.js:49)
    at ClipboardPipeline.editor.plugins.get.on.priority (pastefromoffice.js:68)
    at ClipboardPipeline.fire (emittermixin.js:199)
    at Object.listenTo.priority (clipboardpipeline.js:179)

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@Mgsy Mgsy added type:bug This issue reports a buggy (incorrect) behavior. package:paste-from-office support:2 An issue reported by a commercially licensed client. type:regression This issue reports a bug that was not present in the previous releases. squad:core Issue to be handled by the Core team. labels Jun 25, 2021
@AnnaTomanek AnnaTomanek added this to the iteration 45 milestone Jul 5, 2021
@FliegendeWurst
Copy link

#9055 (comment) looks like the same issue

@pomek
Copy link
Member

pomek commented Jul 6, 2021

As I can see, I wasn't alone working on the issue :/

Proposed solution: #10084.

@pomek pomek self-assigned this Jul 7, 2021
jacekbogdanski added a commit that referenced this issue Jul 7, 2021
Fix (paste-from-office): Fixed a crash when pasting lists from Word to the editor. Closes #9055. Closes #9954.
@AntonTomilov
Copy link

Still reproducible in CKEditor version 31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:paste-from-office squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants