Invalid dependencies in ckeditor5-theme-lark - all deps should be dev deps

[mlewand]

Provide a description of the task

In theme lark:

ckeditor5/packages/ckeditor5-theme-lark/package.json

Lines 12 to 37 in d903bc5

	"@ckeditor/ckeditor5-basic-styles": "^28.0.0",
	"@ckeditor/ckeditor5-ckfinder": "^28.0.0",
	"@ckeditor/ckeditor5-code-block": "^28.0.0",
	"@ckeditor/ckeditor5-core": "^28.0.0",
	"@ckeditor/ckeditor5-editor-balloon": "^28.0.0",
	"@ckeditor/ckeditor5-editor-classic": "^28.0.0",
	"@ckeditor/ckeditor5-find-and-replace": "^0.0.1",
	"@ckeditor/ckeditor5-font": "^28.0.0",
	"@ckeditor/ckeditor5-heading": "^28.0.0",
	"@ckeditor/ckeditor5-highlight": "^28.0.0",
	"@ckeditor/ckeditor5-html-embed": "^28.0.0",
	"@ckeditor/ckeditor5-indent": "^28.0.0",
	"@ckeditor/ckeditor5-link": "^28.0.0",
	"@ckeditor/ckeditor5-list": "^28.0.0",
	"@ckeditor/ckeditor5-media-embed": "^28.0.0",
	"@ckeditor/ckeditor5-page-break": "^28.0.0",
	"@ckeditor/ckeditor5-paragraph": "^28.0.0",
	"@ckeditor/ckeditor5-remove-format": "^28.0.0",
	"@ckeditor/ckeditor5-restricted-editing": "^28.0.0",
	"@ckeditor/ckeditor5-select-all": "^28.0.0",
	"@ckeditor/ckeditor5-source-editing": "^0.0.1",
	"@ckeditor/ckeditor5-special-characters": "^28.0.0",
	"@ckeditor/ckeditor5-ui": "^28.0.0",
	"@ckeditor/ckeditor5-undo": "^28.0.0",
	"@ckeditor/ckeditor5-utils": "^28.0.0",
	"@ckeditor/ckeditor5-table": "^28.0.0",

We have all the deps marked as regular dependencies, but we use them only in manual test - so that's purely dev dep. Not sure if that's true for all the packages, but certainly most of them, like ckeditor5-find-and-replace.

[przemyslaw-zan]

Seems like these files are in fact in use in ckeditor5-theme-lark/theme/

[mlewand]

The question is why does our validator says that? Let's take a single example @ckeditor/ckeditor5-media-embed package.

I made a ctrl+shif+f search in theme package and the only match is in this line:

ckeditor5/packages/ckeditor5-theme-lark/tests/manual/iconset.js

Line 53 in cf9cac0

import media from '@ckeditor/ckeditor5-media-embed/theme/icons/media.svg';

That's a manual test so it's a dev dep. Is there any other media embed usage in there?

[przemyslaw-zan]

.ck.ck-code-block-dropdown .ck-dropdown__panel {

Perhaps references in css files cause that?

[psmyrek]

Currently, the decision if given package should belong to dependencies or devDependencies depends on this function:

function isDevDependency( absolutePaths ) {
    return !absolutePaths.some( absolutePath => absolutePath.match( /src|theme/ ) );
}

A package is a devDependency if it is not used in the source and theme.

The bug here is because the absolutePath for ckeditor5-theme-lark package already contains the theme word (from the package name), so all packages imported in the ckeditor5-theme-lark will always be classified as dependencies.

[pomek]

Updating the RegExp to check only directories would resolve the problem. Keep in mind that the RegExp should work on both environments: Unix-like (/) and Windows (\).

[pomek]

Fix for the dep-checker was released: https://github.com/ckeditor/ckeditor5-dev/releases/tag/v25.2.6.

[pomek]

Miss click.

[przemyslaw-zan]

Fix is in, but some dependencies are still marked as misplaced

[pomek]

On Unix-like OS:

[przemyslaw-zan]

The following packages are used in the source and should be moved to `dependencies`
- @ckeditor/ckeditor5-basic-styles
- @ckeditor/ckeditor5-core
- @ckeditor/ckeditor5-utils

On Windows, these 3 dependencies still refuse to be moved into dev dependencies, but this will probably be a new ticket.