[WIP] Fixed baloon position when viewportTopOffset is set #10120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawidurbanski
changed the title
This was referenced Aug 16, 2021
|
Closed in favour of #10373 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
This PR aims to apply fix to all the contextual balloons for either very tall elements (like super long table, or very tall image etc), that are taller than the editor scrollable area, and also to prevent some balloons to hide under other absolutely / fixed positioned UI elements when
viewportTopOffsetis specified in the editor config.Type: Message. Closes #9892.
Additional information
I'm going to put more insights to this big issue in the ticket comments (#9892)
Manual test case with fixed balloons for mentioned cases can be checked under (tickets/9892/1.html) test by running:
All the editors and sample manual test cases that are using contextual balloons can be run this way:
This PR is still work in progress. For example there are no tests for new cases.
It's done in a way to make all previous tests to pass.