Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more known key codes #10546

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Add more known key codes #10546

merged 2 commits into from
Sep 17, 2021

Conversation

arkflpc
Copy link
Contributor

@arkflpc arkflpc commented Sep 16, 2021

Suggested merge commit message (convention)

Fix(utils): Adds more known key codes. For instance, to allow CTRL-]. Closes #10439.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

Copy link
Contributor

@niegowski niegowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more tests to make sure keyCodes, getCode(), parseKeystroke() also work correctly with new keys.

Also in the scope was also:

make sure that the utils in keyboard.js throw a meaningful error when passed an unknown key

@niegowski niegowski merged commit 52b3732 into master Sep 17, 2021
@niegowski niegowski deleted the ck/10439-add-more-key-codes branch September 17, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The getEnvKeystrokeText utility breaks for certain combos starting in v26
2 participants