Ck/11718 typescript in dll #11962
Merged
Ck/11718 typescript in dll #11962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkflpc
changed the base branch from
master
to
ck/epic/11708-migrate-typescript-mvp
pomek
reviewed
Jul 11, 2022
| @@ -16,8 +16,7 @@ import FindNextCommand from './findnextcommand'; | |||
| import FindPreviousCommand from './findpreviouscommand'; | |||
| import FindAndReplaceState from './findandreplacestate'; | |||
|
|
|||
| // eslint-disable-next-line ckeditor5-rules/ckeditor-imports | |||
| import { scrollViewportToShowTarget } from '@ckeditor/ckeditor5-utils/src/dom/scroll'; | |||
| import { scrollViewportToShowTarget } from 'ckeditor5/src/utils'; | |||
There was a problem hiding this comment.
This is an unrelated change to the scope of the PR. I believe it should land on #master. Could you report a follow-up for it?
There was a problem hiding this comment.
I believe I saw an error because of that, so I fixed it. I don't see it anymore, so I'm going to remove this change from PR
|
Before:
After:
Works as expected. However, due to conflicting files, I cannot merge it. Please, merge the base branch, and feel free to merge the PR once CI is green. |
…-mvp' into ck/11718-typescript-in-dll
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Adds support for TypeScript when building core DLL. Closes #11718.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.