Handle call to navigator API for envs without navigator API. #11999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change requires tests. How do we know that it actually doesn't crash later on when the string is empty? Also, perhaps it'd be better if a "no browser" tried to mimick some known browser? Chrome for instance as it's most popular? |
packages/ckeditor5-utils/src/env.js
Outdated
| const userAgent = navigator.userAgent.toLowerCase(); | ||
| // This file might be imported in environments without the navigator API. | ||
| /* istanbul ignore next */ | ||
| const userAgent = navigator ? navigator.userAgent.toLowerCase() : ''; |
There was a problem hiding this comment.
It doesn't work. Still, the result is:
ReferenceError: navigator is not defined
When I replaced this line to const userAgent = ''; then it went on, but threw another error:
ReferenceError: window is not defined
When I fixed all places it started to work 🎉
Places that I have changed:
- global.js ->
export default { window: {}, document: {} }; - env.js ->
const userAgent = ''; - translation-service.js -> replaced
windowtoglobal - version.js ->
const windowOrGlobal = global;Probably changes are not required because when I revert it back, it was still working
dpawlowski-cksource
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal (utils): Wrapped accessing browser's API in try/catch blocks to safely initialize editor in environments without browser's APIs.
Additional information
env.ts,global.tsandtranslation-service.tsfiles might be imported in environments without browsers' APIs - like Node.The best solution would be to get it out of a global scope to a function call, so it's not executed on the file import, but that would require a change in fifty files wherever it's imported.