Ck/12125 dropdown focus #12162
Merged
Ck/12125 dropdown focus #12162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6f387c4.
|
@ckeditor/qa-team Hi, please take a look at this PR and ensure it doesn't introduce some regressions. |
|
I've tested it in all browsers with different editor types and haven't found any issue. |
|
Seems that unit tests are failing for: Per https://app.travis-ci.com/github/ckeditor/ckeditor5/jobs/577951169 |
|
Let's do a final QA testing, that includes:
The CKE5 itself has been already well covered by @Mgsy so he don't need to do this particular part that much (contrary to @FilipTokarski 😈). Let's test |
This comment was marked as outdated.
This comment was marked as outdated.
FilipTokarski
approved these changes
Jul 28, 2022
Mgsy
approved these changes
Jul 28, 2022
|
Extracted #12162 (comment) to #12178. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal: Dropdown will move focus to the button after an option is picked from the list. Closes #12125. Closes #12121.
Additional information
See the details in #12125 (comment).