-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies #1234
Upgrade dependencies #1234
Conversation
CKEditor 5 and CKEditor 5-dev are fine. |
Let's not upgrade lerna to version 3 (just yet) due to problems and other options mentioned in #1214. |
As you wish but everything seems to work. |
I actually tried to upgrade to lerna@3 myself and I knew it caused some issues (although, I stumbled upon something else than you). |
Lerna 3 changes some things in configuration ( Docs worked, samples in the docs as well. I didn't check the builds. |
After reverting lerna's changes, ckeditor5-dev does not require any changes. |
There are packages in ckeditor5-dev that we should upgrade now. For instance: And there are more in ckeditor5-dev that require updates. We should keep them in sync with what we use in ckeditor5 to avoid problems like – |
Suggested merge commit message (convention)
Internal: Upgraded dev-dependencies. Closes #1203.
Additional information
#t/ckeditor5/1203
in all packages should be merged too:2a80aca and 38cec00 need to be reverted before merging